Skip to content

Fix nix shell#5561

Merged
f-f merged 1 commit intomasterfrom
f-f/update-flake-20260204
Feb 5, 2026
Merged

Fix nix shell#5561
f-f merged 1 commit intomasterfrom
f-f/update-flake-20260204

Conversation

@f-f
Copy link
Contributor

@f-f f-f commented Feb 4, 2026

Description

#5558 missed a flake update

Checklist

  • Commits in meaningful sequence and with useful messages.
  • Tests added or updated when needed.
  • CHANGELOG.md files updated for packages with externally visible changes.
    NOTE: New section is never added with the code changes. (See RELEASING.md).
  • Versions updated in .cabal and CHANGELOG.md files when necessary, according to the
    versioning process.
  • Version bounds in .cabal files updated when necessary.
    NOTE: If bounds change in a cabal file, that package itself must have a version increase. (See RELEASING.md).
  • Code formatted (use scripts/fourmolize.sh).
  • Cabal files formatted (use scripts/cabal-format.sh).
  • CDDL files are up to date (use scripts/gen-cddl.sh)
  • hie.yaml updated (use scripts/gen-hie.sh).
  • Self-reviewed the diff.

@f-f f-f requested a review from a team as a code owner February 4, 2026 15:43
@teodanciu teodanciu mentioned this pull request Feb 4, 2026
10 tasks
@teodanciu
Copy link
Contributor

teodanciu commented Feb 4, 2026

Is this right though? It is undoing the change made in #5558

from: tag: 3da1ceec493ade9bc6347e342ca51054cc166e78
to: tag: ce149016c8294b9b91a9ee91fdbc449d6bb91a97

Wasn't this change necessary for the other changes in that PR?

Sorry, I'm wrong.

@neilmayhew
Copy link
Contributor

This won't work because the narHash field is unchanged. You need to use nix flake update. The instructions are here.

@f-f f-f force-pushed the f-f/update-flake-20260204 branch from 272c4e0 to fa32e8d Compare February 4, 2026 21:48
@f-f
Copy link
Contributor Author

f-f commented Feb 4, 2026

Oh of course. I pushed the right update. Thanks @neilmayhew!

Copy link
Contributor

@teodanciu teodanciu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me

@f-f f-f merged commit ca970cf into master Feb 5, 2026
122 checks passed
@f-f f-f deleted the f-f/update-flake-20260204 branch February 5, 2026 12:06
@f-f
Copy link
Contributor Author

f-f commented Feb 5, 2026

well that's fun. I tried this locally and the narHash is now wrong? It wants the old hash 🤔

@f-f f-f mentioned this pull request Feb 5, 2026
10 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants