Open
Conversation
aniketd
force-pushed
the
aniketd/subsume-delegations-into-activestake
branch
7 times, most recently
from
ea382c8 to
557033e
Compare
aniketd
force-pushed
the
aniketd/subsume-delegations-into-activestake
branch
from
557033e to
767a164
Compare
lehins
reviewed
Feb 25, 2026
Collaborator
lehins
left a comment
lehins
left a comment
There was a problem hiding this comment.
Very nice! Still needs the usual changelogs and whatnot, but otherwise it is looking good. 💪
libs/cardano-ledger-core/testlib/Test/Cardano/Ledger/Core/Arbitrary.hs
Outdated
Show resolved
Hide resolved
libs/cardano-ledger-core/testlib/Test/Cardano/Ledger/Core/Arbitrary.hs
Outdated
Show resolved
Hide resolved
eras/shelley/test-suite/test/Test/Cardano/Ledger/Shelley/Examples/PoolLifetime.hs
Show resolved
Hide resolved
aniketd
force-pushed
the
aniketd/subsume-delegations-into-activestake
branch
6 times, most recently
from
8cfed39 to
582680d
Compare
Update the activestake field to hold the delegation along with the stake. For this, we introduce the StakeWithDelegation type using NonZero Compact Coin for stake along with the pool Id. In tests, mkActiveStake combines a stake-only and a delegation-only maps.
Also make epochStateStakeDistrL return ActiveStake. Update the golden test.
Update cardano-ledger-shelley-test to use ActiveStake. Update the CBOR codec golden test.
Add HasSimpleRep instance for NonZero (CompactForm Coin).
aniketd
force-pushed
the
aniketd/subsume-delegations-into-activestake
branch
from
582680d to
dffe7ac
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Closes #5577
Checklist
CHANGELOG.mdfiles updated for packages with externally visible changes.NOTE: New section is never added with the code changes. (See RELEASING.md).
.cabalandCHANGELOG.mdfiles when necessary, according to theversioning process.
.cabalfiles updated when necessary.NOTE: If bounds change in a cabal file, that package itself must have a version increase. (See RELEASING.md).
scripts/fourmolize.sh).scripts/cabal-format.sh).scripts/gen-cddl.sh)hie.yamlupdated (usescripts/gen-hie.sh).