JSON output for cardano-cli #3548
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cblp
changed the title
cblp
force-pushed
the
json-output
branch
6 times, most recently
from
f8082a6 to
fd90892
Compare
cblp
requested review from
DavidEichmann,
dcoutts,
Jimbo4350,
erikd,
newhoggy,
nc6 and
JaredCorduan
as code owners
cblp
changed the title
|
the ' |
|
Voting up! It's a pity it looks stalled. |
newhoggy
requested review from
LudvikGalois and
CarlosLopezDeLara
as code owners
newhoggy
requested review from
deepfire,
jutaro,
mgmeier,
fmaste and
cleverca22
as code owners
newhoggy
force-pushed
the
json-output
branch
3 times, most recently
from
7885e10 to
ebfd78c
Compare
newhoggy
force-pushed
the
json-output
branch
3 times, most recently
from
30ae7e6 to
2824a1a
Compare
carbolymer
reviewed
Apr 11, 2023
| @@ -105,6 +109,52 @@ instance ToCBOR Certificate where | |||
| instance FromCBOR Certificate where | |||
| fromCBOR = fromShelleyCertificate <$> fromCBOR | |||
|
|
|||
| instance ToJSON Certificate where | |||
There was a problem hiding this comment.
I'm wondering if it would be possible here to change constructors to records and then use genericToJSON with constructorTagModifier instead of manual instances?
There was a problem hiding this comment.
I think we prefer explicit instances. @Jimbo4350 do you have an opinion on genericToJSON?
carbolymer
reviewed
Apr 11, 2023
carbolymer
approved these changes
Apr 11, 2023
newhoggy
force-pushed
the
json-output
branch
4 times, most recently
from
032ac17 to
a1cb8ac
Compare
* Certificate * MIRTarget * StakePoolParameters * StakePoolRelay * StakePoolMetadataReference
* ProtocolParametersUpdate * UpdateProposal
* WitVKey 'Witness crypto * KeyWitness era
* PlutusScriptVersion lang * Script lang * ScriptInEra era * PlutusScript lang
* TxAuxScripts era * TxBodyContent ViewTx era * TxCertificates ViewTx era * TxExtraKeyWitnesses era * TxFee era * TxInsCollateral era * TxInsReference build era * TxMetadataInEra era * TxMintValue ViewTx era * TxReturnCollateral CtxTx era * TxScriptValidity era * TxTotalCollateral era * TxUpdateProposal era * TxValidityLowerBound era * TxValidityUpperBound era * TxWithdrawals ViewTx era
carbolymer
reviewed
May 10, 2023
| instance ToJSON ProtocolParametersUpdate where | ||
| toJSON ref = | ||
| object $ | ||
| ( ("protocolVersion" ..=? protocolUpdateProtocolVersion ref) |
There was a problem hiding this comment.
If we have Generic instance available here already, why not use genericToJSON? 😃
carbolymer
reviewed
May 10, 2023
| @@ -868,6 +898,13 @@ instance FromCBOR UpdateProposal where | |||
| <$> fromCBOR | |||
| <*> fromCBOR | |||
|
|
|||
| instance ToJSON UpdateProposal where | |||
There was a problem hiding this comment.
why not convert UpdateProposal to a record and then use genericToJSON?
carbolymer
reviewed
May 10, 2023
| {-# LANGUAGE RankNTypes #-} | ||
| {-# LANGUAGE ScopedTypeVariables #-} | ||
| {-# LANGUAGE TypeApplications #-} | ||
| {-# LANGUAGE UndecidableInstances #-} |
There was a problem hiding this comment.
I'm wondering if there is a way to avoid using Undecidableinstances here? Maybe this could be solved by OVERLAPPING / OVERLAPPABLE?
carbolymer
reviewed
May 10, 2023
| @@ -281,6 +280,8 @@ import Cardano.Api.Utils | |||
| import Cardano.Api.Value | |||
| import Cardano.Api.ValueParser | |||
|
|
|||
| -- import Cardano.Chain.UTxO (Tx (..)) | |||
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #3213
Changes (planned)
query utxo--out-filewrites JSONtransaction view--out-filewrites JSONtransaction calculate-min-fee--out-filewrites JSON