-
Notifications
You must be signed in to change notification settings - Fork 733
New tracing system support #6133
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Draft
johnalotoski
wants to merge
37
commits into
master
Choose a base branch
from
jl/new-tracing-service
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Draft
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
b790e41
to
548e33a
Compare
228d83b
to
374e4eb
Compare
cbce577
to
5a8a374
Compare
afc184b
to
544c649
Compare
e138d63
to
08c2118
Compare
9c15e0f
to
1e8b076
Compare
5c0fb38
to
20e921c
Compare
* Update usePeersFromLedgerAfterSlot to useLedgerAfterSlot for consistent naming with the cardano-node topology file key.
…g w/ filteredOpts
4b4a335
to
a220eca
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR changes the default tracing system to the new tracing system and implements support for this where needed:
Nixos cardano-node service:
usePeersFromLedgerAfterSlot
has been renamed touseLedgerAfterSlot
for consistency with the topology file key value it setstopology[-$i].yaml
totopology[-$i].json
to reflect json contentsNixos cardano-tracer pre-existing service:
nix/nixos/cardano-tracer-service-workbench.nix
, suitable for internal usenix/nixos/module-list.nix
for default importsNixos cardano-tracer new service:
nix/nixos/module-list.nix
for default importsNixos scripts:
nix build -L .#scripts.$NETWORK.tracer
, similar to the pre-existing node and submit-api scriptsstate-tracer-$NETWORK
is the default relative path state dirNixos tests:
nix/nixos/tests/cardano-node-edge.nix
with shorter timeouts and prometheusSimple supported cardano-cli ping checkDocker:
nix build -L .#dockerImage/tracer
scripts
,custom
andmerge
modesnix/docker/README.md
to add cardano-tracer documentation, including example usage and node-to-tracer discussionWorkbench service tracer changes:
nix/workbench/service/tracer.nix
logic was added to utilize either the internal workbench or generic cardano-tracer nixos serviceuseWorkbenchTracerService
bool was added to select which cardano-tracer service is usedCardano Tests:
mainnet-config.json
which now contain config for the new tracing systemmainnet-config-legacy.json
Configuration:
configuration/cardano
directory has had configuration files updated such that:mainnet-config.json
now contains new tracing system configmainnet-config.yaml
now contains new tracing system configmainnet-config-bp.json
now contains new tracing system configmainnet-config-legacy.json
now contains legacy tracing system configtestnet-template-config.json
now contains new tracing system configMakefile
was updated to useconfiguration/cardano/mainnet-config.yaml
which now contains new tracing system configBash scripts:
scripts/lite/mainnet.sh
has been updated to run new tracing systemscripts/lite/mainnet-new-tracing.sh
, which is no longer necessary as it is now the default, shown in the line above, has been changed toscripts/list/mainnet-legacy-tracing.sh
with an appropriate legacy config ref updateCI:
Checklist