cardano-testnet: remove unused enable P2P option #6154
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
smelc
force-pushed
the
smelc/cardano-testnet-remove-unused-option
branch
2 times, most recently
from
f8ad07e to
5a2bd94
Compare
carbolymer
approved these changes
Mar 18, 2025
smelc
force-pushed
the
smelc/cardano-testnet-remove-unused-option
branch
from
5a2bd94 to
cecdf60
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
While working on other issues, I noticed that the
enable P2Poption was not implemented, so this PR removes it.This is in line with #6148 and #6137 that move towards implementing such flags using the node's configuration file, instead of having dedicated flags.
Checklist