renamed ForkPolicy configuration option as ResponderCoreAffinityPolicy #6192
+27
−22
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Jimbo4350
approved these changes
Apr 24, 2025
| -- * `ResponderForkPolicy` corresponds to `Ouroboros.Network.Mux.responderForkPolicy` | ||
| -- | We expose the `Mux.ForkPolicy` as a `NodeConfiguration` field. | ||
| -- | ||
| -- * `NoResponderCoreAffinity` corresponds to `Mux.noBindForkPolicy` |
There was a problem hiding this comment.
What do these mean however? Can you link to documentation?
There was a problem hiding this comment.
It ought to be linked through haddocks, but there's something wrong with your haddocks pipeline: https://cardano-node.cardano.intersectmbo.org/cardano-node/Cardano-Node-Configuration-POM.html
There was a problem hiding this comment.
It will work if:
- in this PR we use full module names rather than qualification (which likely is is a bug in haddock)
- use a newer version of
cabal(I tested it withcabal-0.14.2.0) (one needs to get rid of the--localswitch which was removed fromcabal project-haddockcommand). Thenix developexposescabal-install-3.10.3.0. - in your
github-pageaction you might need to use a customcabal.project.localfile which enables documentation for dependencies. Locally I have:
documentation: False
package ouroboros-network-framework
documentation: True
and it worked, but it's probably enough to change documentation: True and not include the per-package specific option (which would be annoying if one needed to do that for all dependencies); or maybe a custom cabal.project.local file is not needed at all.
coot
force-pushed
the
coot/responder-core-affinity-policy
branch
2 times, most recently
from
937dd88 to
7411412
Compare
coot
force-pushed
the
coot/responder-core-affinity-policy
branch
from
7411412 to
6ebb8d0
Compare
github-merge-queue
bot
removed this pull request from the merge queue due to failed status checks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.