Skip to content

Print warning on group permissions check for VRF instead of failing to start the node. #6203

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

carbolymer
Copy link
Contributor

Description

Fixes #6160

Checklist

  • Commit sequence broadly makes sense and commits have useful messages
  • New tests are added if needed and existing tests are updated. These may include:
    • golden tests
    • property tests
    • roundtrip tests
    • integration tests
      See Runnings tests for more details
  • Any changes are noted in the CHANGELOG.md for affected package
  • The version bounds in .cabal files are updated
  • CI passes. See note on CI. The following CI checks are required:
    • Code is linted with hlint. See .github/workflows/check-hlint.yml to get the hlint version
    • Code is formatted with stylish-haskell. See .github/workflows/stylish-haskell.yml to get the stylish-haskell version
    • Code builds on Linux, MacOS and Windows for ghc-9.6 and ghc-9.12
  • Self-reviewed the diff

Note on CI

If your PR is from a fork, the necessary CI jobs won't trigger automatically for security reasons.
You will need to get someone with write privileges. Please contact IOG node developers to do this
for you.

@carbolymer carbolymer marked this pull request as ready for review April 30, 2025 15:17
@carbolymer carbolymer requested review from a team as code owners April 30, 2025 15:17
@carbolymer carbolymer force-pushed the mgalazyn/feature/add-skiping-of-group-permission-checks branch from 475df34 to 6137ced Compare April 30, 2025 15:29
@carbolymer carbolymer self-assigned this Apr 30, 2025
Copy link
Contributor

@Jimbo4350 Jimbo4350 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm hesitate about adding another argument to the cardano-node executable. Can you check with @disassembler if we can just disable the permission check all together? Or just issue a warning if the permissions aren't set?

@carbolymer carbolymer force-pushed the mgalazyn/feature/add-skiping-of-group-permission-checks branch from 6137ced to 3eaf3e0 Compare May 16, 2025 11:22
@carbolymer carbolymer changed the title Add --skip-key-group-permission-check command line argument, disabling group permissions check for VRF key. Print warning on group permissions check for VRF instead of failing to start the node. May 16, 2025
@carbolymer carbolymer requested a review from Jimbo4350 May 16, 2025 11:22
@carbolymer carbolymer force-pushed the mgalazyn/feature/add-skiping-of-group-permission-checks branch from 3eaf3e0 to efd084d Compare May 16, 2025 11:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

cardano-node will prevent usage of keys and certificates when the systemd credential subsystem is used
2 participants