Skip to content

Update cardano-cli. Remove redundant AsType constructors usages. #6204

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
May 16, 2025

Conversation

carbolymer
Copy link
Contributor

@carbolymer carbolymer commented May 1, 2025

Description

Update cardano-cli-10.9.0.0 & cardano-api-10.16.0.0. Remove redundant AsType constructors usages.

Checklist

  • Commit sequence broadly makes sense and commits have useful messages
  • New tests are added if needed and existing tests are updated. These may include:
    • golden tests
    • property tests
    • roundtrip tests
    • integration tests
      See Runnings tests for more details
  • Any changes are noted in the CHANGELOG.md for affected package
  • The version bounds in .cabal files are updated
  • CI passes. See note on CI. The following CI checks are required:
    • Code is linted with hlint. See .github/workflows/check-hlint.yml to get the hlint version
    • Code is formatted with stylish-haskell. See .github/workflows/stylish-haskell.yml to get the stylish-haskell version
    • Code builds on Linux, MacOS and Windows for ghc-9.6 and ghc-9.12
  • Self-reviewed the diff

Note on CI

If your PR is from a fork, the necessary CI jobs won't trigger automatically for security reasons.
You will need to get someone with write privileges. Please contact IOG node developers to do this
for you.

@carbolymer carbolymer self-assigned this May 1, 2025
@carbolymer carbolymer force-pushed the mgalazyn/chore/remove-redundant-astype-usages branch from 9128662 to 04b1e21 Compare May 15, 2025 11:51
@carbolymer carbolymer changed the title Remove redundant AsType constructors usages Update cardano-cli. Remove redundant AsType constructors usages. May 15, 2025
@carbolymer carbolymer marked this pull request as ready for review May 15, 2025 11:52
@carbolymer carbolymer requested review from a team as code owners May 15, 2025 11:52
@carbolymer carbolymer force-pushed the mgalazyn/chore/remove-redundant-astype-usages branch from 04b1e21 to 39aa7be Compare May 15, 2025 12:38
@carbolymer carbolymer marked this pull request as draft May 15, 2025 13:09
@carbolymer carbolymer force-pushed the mgalazyn/chore/remove-redundant-astype-usages branch from 39aa7be to 528634c Compare May 15, 2025 15:02
@carbolymer carbolymer force-pushed the mgalazyn/chore/remove-redundant-astype-usages branch from 528634c to 1ef257e Compare May 15, 2025 15:03
@carbolymer carbolymer marked this pull request as ready for review May 15, 2025 15:04
@carbolymer carbolymer force-pushed the mgalazyn/chore/remove-redundant-astype-usages branch from 1ef257e to 5f27d9b Compare May 15, 2025 15:38
@carbolymer carbolymer added this pull request to the merge queue May 16, 2025
Merged via the queue into master with commit e9bb755 May 16, 2025
22 of 24 checks passed
@carbolymer carbolymer deleted the mgalazyn/chore/remove-redundant-astype-usages branch May 16, 2025 07:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants