Skip to content

Fix exit code for SIGTERM #6212

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 2 commits into from
Closed

Fix exit code for SIGTERM #6212

wants to merge 2 commits into from

Conversation

karknu
Copy link
Contributor

@karknu karknu commented May 7, 2025

Description

When catching SIGTERM the node does a clean exit, but its exit status is 1. This makes it impossible to differentiate between a clean shutdown triggered by SIGTERM and a crash.

This changes it so that cardano-node exits with 0 when exiting due to catching SIGTERM.

Checklist

  • Commit sequence broadly makes sense and commits have useful messages
  • New tests are added if needed and existing tests are updated. These may include:
    • golden tests
    • property tests
    • roundtrip tests
    • integration tests
      See Runnings tests for more details
  • Any changes are noted in the CHANGELOG.md for affected package
  • The version bounds in .cabal files are updated
  • CI passes. See note on CI. The following CI checks are required:
    • Code is linted with hlint. See .github/workflows/check-hlint.yml to get the hlint version
    • Code is formatted with stylish-haskell. See .github/workflows/stylish-haskell.yml to get the stylish-haskell version
    • Code builds on Linux, MacOS and Windows for ghc-9.6 and ghc-9.12
  • Self-reviewed the diff

Note on CI

If your PR is from a fork, the necessary CI jobs won't trigger automatically for security reasons.
You will need to get someone with write privileges. Please contact IOG node developers to do this
for you.

@karknu karknu force-pushed the karknu/sigterm_exit branch 2 times, most recently from 1e792ae to 1aa6637 Compare May 15, 2025 07:14
@karknu karknu marked this pull request as ready for review May 15, 2025 07:16
@karknu karknu requested a review from a team as a code owner May 15, 2025 07:16
When catching SIGTERM the node does a clean exit, but its exit status is
1. This makes it impossible to differentiate between a clean shutdown
triggered by SIGTERM and a crash.

This changes it so that cardano-node exits with 0 when exiting due to catching
SIGTERM.
@karknu karknu force-pushed the karknu/sigterm_exit branch from 1aa6637 to 657dd73 Compare May 15, 2025 15:22
Copy link
Contributor

@Jimbo4350 Jimbo4350 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, can you squash the commits?

@karknu
Copy link
Contributor Author

karknu commented May 20, 2025

LGTM, can you squash the commits?

Thanks but @crocodile-dentist has already cherry-picked this commit into your 10.5 branch so I don't think this PR is needed anymore.

@karknu karknu closed this May 20, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants