Skip to content

Misc fixes #6230

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 2 commits into
base: master
Choose a base branch
from
Open

Misc fixes #6230

wants to merge 2 commits into from

Conversation

karknu
Copy link
Contributor

@karknu karknu commented May 27, 2025

Description

Fix genesis sync. target.
Bump chap timestamp so that input-output-hk/iohk-monitoring-framework#654 is included.

Checklist

  • Commit sequence broadly makes sense and commits have useful messages
  • New tests are added if needed and existing tests are updated. These may include:
    • golden tests
    • property tests
    • roundtrip tests
    • integration tests
      See Runnings tests for more details
  • Any changes are noted in the CHANGELOG.md for affected package
  • The version bounds in .cabal files are updated
  • CI passes. See note on CI. The following CI checks are required:
    • Code is linted with hlint. See .github/workflows/check-hlint.yml to get the hlint version
    • Code is formatted with stylish-haskell. See .github/workflows/stylish-haskell.yml to get the stylish-haskell version
    • Code builds on Linux, MacOS and Windows for ghc-9.6 and ghc-9.12
  • Self-reviewed the diff

Note on CI

If your PR is from a fork, the necessary CI jobs won't trigger automatically for security reasons.
You will need to get someone with write privileges. Please contact IOG node developers to do this
for you.

@karknu karknu force-pushed the karknu/10.5.0_mix branch from 8783a72 to 350ec3c Compare May 27, 2025 05:59
karknu added 2 commits May 27, 2025 08:00
XXX Should be done in ouroboros-network.
move timestamp to pick up new version of iohk-monitoring
@karknu karknu force-pushed the karknu/10.5.0_mix branch from 350ec3c to 066a4bb Compare May 27, 2025 06:00
@karknu karknu marked this pull request as ready for review May 27, 2025 06:01
@karknu karknu requested a review from a team as a code owner May 27, 2025 06:01
Copy link
Contributor

@coot coot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The proper fix is here: ouroboros-network#5127.

Comment on lines +1064 to +1073
-- TODO remove and use defaultSyncTargets for next o-n-release.
defaultSyncTargets' :: PeerSelectionTargets -> PeerSelectionTargets
defaultSyncTargets' deadlineTargets =
deadlineTargets {
targetNumberOfActivePeers = 0,
targetNumberOfKnownBigLedgerPeers = 100,
targetNumberOfEstablishedBigLedgerPeers = 50,
targetNumberOfActiveBigLedgerPeers = 30 }


Copy link
Contributor

@coot coot May 27, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It's already there: IntersectMBO/ouroboros-network#5127.

btw, your sync targets are exactly the same as the ones in ouroboros-network-0.21.0.0.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Not yet , but with IntersectMBO/ouroboros-network#5128 it will be.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants