Skip to content

Update to new cardano-api's module structure. Remove usages of partial IsString instances. #6234

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Draft
wants to merge 2 commits into
base: master
Choose a base branch
from

Conversation

carbolymer
Copy link
Contributor

@carbolymer carbolymer commented May 28, 2025

Description

This PR removes fromString invocations in cardano-testnet which are partial, where are not necessary. TxId is used instead of String carrying its hex representation.

Integrates changes from:

Checklist

  • Commit sequence broadly makes sense and commits have useful messages
  • New tests are added if needed and existing tests are updated. These may include:
    • golden tests
    • property tests
    • roundtrip tests
    • integration tests
      See Runnings tests for more details
  • Any changes are noted in the CHANGELOG.md for affected package
  • The version bounds in .cabal files are updated
  • CI passes. See note on CI. The following CI checks are required:
    • Code is linted with hlint. See .github/workflows/check-hlint.yml to get the hlint version
    • Code is formatted with stylish-haskell. See .github/workflows/stylish-haskell.yml to get the stylish-haskell version
    • Code builds on Linux, MacOS and Windows for ghc-9.6 and ghc-9.12
  • Self-reviewed the diff

Note on CI

If your PR is from a fork, the necessary CI jobs won't trigger automatically for security reasons.
You will need to get someone with write privileges. Please contact IOG node developers to do this
for you.

@carbolymer carbolymer requested a review from a team as a code owner May 28, 2025 15:11
@carbolymer carbolymer self-assigned this May 28, 2025
@carbolymer carbolymer force-pushed the mgalazyn/test/remove-fromstring branch 2 times, most recently from aa51af9 to d38d01e Compare May 28, 2025 16:08
@carbolymer carbolymer marked this pull request as draft May 29, 2025 10:22
@carbolymer
Copy link
Contributor Author

carbolymer commented May 29, 2025

Back to "draft" because deriving Show via (UsingRawBytesHex a) is quoting the string. Added Pretty instance in: IntersectMBO/cardano-api#842

@carbolymer carbolymer force-pushed the mgalazyn/test/remove-fromstring branch from d38d01e to a3c48a5 Compare June 2, 2025 20:46
@carbolymer carbolymer force-pushed the mgalazyn/test/remove-fromstring branch from a3c48a5 to d21bc45 Compare June 5, 2025 17:17
@carbolymer carbolymer force-pushed the mgalazyn/test/remove-fromstring branch from 7b0971c to 2674160 Compare June 10, 2025 05:24
@carbolymer carbolymer changed the title cardano-testnet | remove fromString where not needed Update to new cardano-api's module structure. Remove usages of partial IsString instances. Jun 10, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants