Add an option to dump/load configuration sandbox in cardano-testnet
#6239
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Jimbo4350
reviewed
Jun 5, 2025
cardano-testnet/test/cardano-testnet-test/Cardano/Testnet/Test/DumpConfig.hs
Outdated
Show resolved
Hide resolved
| @@ -164,46 +165,22 @@ cardanoTestnet :: () | |||
| => HasCallStack | |||
| => CardanoTestnetOptions -- ^ The options to use | |||
| -> GenesisOptions | |||
| -> UserProvidedData ShelleyGenesis | |||
There was a problem hiding this comment.
Unfortunately, I had to put those back: some tests use it to create an env with custom parameters. Maybe I should modify the config files on disk since that's now possible?
nbacquey
force-pushed
the
nbacquey/dump_config
branch
9 times, most recently
from
ea046e0 to
f86dc4b
Compare
nbacquey
force-pushed
the
nbacquey/dump_config
branch
from
f86dc4b to
3f192d1
Compare
Jimbo4350
approved these changes
Jun 23, 2025
| @@ -106,17 +106,17 @@ hprop_gov_no_confidence = integrationWorkspace "no-confidence" $ \tempAbsBasePat | |||
|
|
|||
| let conwayGenesisWithCommittee = defaultConwayGenesis { L.cgCommittee = committee } | |||
|
|
|||
| createTestnetEnv | |||
github-merge-queue
bot
removed this pull request from the merge queue due to failed status checks
github-merge-queue bot
pushed a commit
that referenced
this pull request
Jun 24, 2025
Add an option to dump/load configuration sandbox in `cardano-testnet`
github-merge-queue
bot
removed this pull request from the merge queue due to failed status checks
github-merge-queue
bot
removed this pull request from the merge queue due to no response for status checks
github-merge-queue
bot
removed this pull request from the merge queue due to failed status checks
This disables checking for hashes when loading individual genesis files, which in turn allows for on-the-fly configuration modifications, without having to recompute the hashes each time.
nbacquey
force-pushed
the
nbacquey/dump_config
branch
from
fb0c257 to
ba03c10
Compare
github-merge-queue
bot
removed this pull request from the merge queue due to no response for status checks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR introduces a new
create-envsub-command tocardano-testnet, which creates a sandboxed environment with default parameters, which can then be modified by hand and passed to the maincardanosubcommand with the--node-envoption.This PR should be reviewed commit by commit.
Checklist
See Runnings tests for more details
CHANGELOG.mdfor affected packagehlint. See.github/workflows/check-hlint.ymlto get thehlintversionstylish-haskell. See.github/workflows/stylish-haskell.ymlto get thestylish-haskellversionghc-9.6andghc-9.12Note on CI
If your PR is from a fork, the necessary CI jobs won't trigger automatically for security reasons.
You will need to get someone with write privileges. Please contact IOG node developers to do this
for you.