Skip to content

Make lint-actionlint.sh also consider *.yml files #722

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
May 15, 2025

Conversation

jeltsch
Copy link
Collaborator

@jeltsch jeltsch commented May 14, 2025

Previously, scripts/lint-actionlint.sh only considered files whose paths match the pattern .github/workflows/*.yaml. However, the only workflow file that we currently have has the path .github/workflows/ci.yml, which doesn’t match the above-mentioned pattern. This pull request extends scripts/lint-actionlint.sh to also consider files whose paths match the pattern .github/workflows/*.yml.

@jeltsch jeltsch requested review from dcoutts and jorisdral as code owners May 14, 2025 19:54
@jeltsch jeltsch added the bug Something isn't working label May 14, 2025
@jeltsch jeltsch self-assigned this May 14, 2025
@wenkokke
Copy link
Collaborator

You may want to add the sections as well, if that's something actionlint supports.

@jeltsch
Copy link
Collaborator Author

jeltsch commented May 14, 2025

You may want to add the sections as well, if that's something actionlint supports.

What sections do you mean?

By the way, would it make sense to have actionlint also cover the files actions/*/action.yaml, or are these not supported by actionlint? Sorry, I have no idea what actionlint precisely does. 😅

@wenkokke
Copy link
Collaborator

I meant actions, but autocorrect undermined me.

@jeltsch
Copy link
Collaborator Author

jeltsch commented May 14, 2025

I meant actions, but autocorrect undermined me.

Alright: So we talked about the same thing then. I’ll check tomorrow what happens if I add the action files.

@jeltsch
Copy link
Collaborator Author

jeltsch commented May 15, 2025

I’ll check tomorrow what happens if I add the action files.

I’m back at this now but will tackle it in a new pull request.

@jeltsch jeltsch force-pushed the jeltsch/actionlint-for-yml branch from 2c641d0 to b4b4172 Compare May 15, 2025 16:24
@jeltsch jeltsch enabled auto-merge May 15, 2025 16:24
@jeltsch jeltsch added this pull request to the merge queue May 15, 2025
Merged via the queue into main with commit 583aab6 May 15, 2025
28 checks passed
@jeltsch jeltsch deleted the jeltsch/actionlint-for-yml branch May 15, 2025 17:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants