consensus: more carefully hide HeaderWithTime from traces
#1498
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
geo2a
requested review from
nfrisby,
jasagredo,
amesgen,
fraser-iohk,
dnadales and
jorisdral
as code owners
amesgen
reviewed
May 7, 2025
ouroboros-consensus/src/ouroboros-consensus/Ouroboros/Consensus/Genesis/Governor.hs
Outdated
Show resolved
Hide resolved
ouroboros-consensus/src/ouroboros-consensus/Ouroboros/Consensus/Genesis/Governor.hs
Outdated
Show resolved
Hide resolved
amesgen
approved these changes
May 7, 2025
| @@ -354,7 +354,7 @@ densityDisconnect (GenesisWindow sgen) (SecurityParam k) states candidateSuffixe | |||
| where | |||
| densityBounds = do | |||
| (peer, candidateSuffix) <- candidateSuffixes | |||
| let (clippedFragment, _) = | |||
| let (clippedFragmentWithTime, _) = | |||
There was a problem hiding this comment.
(No action required in this PR.)
This WithTime suffix feels like a distraction, the GDD doesn't care about time at all. I think the "proper" thing to do here would be to make the code more abstract, ie consuming AnchoredFragment hdr0/AnchoredFragment hdr1, and doing the transformation in the tracer (via its Contravariant instance) instead.
This is a follow-up to eb8f344 merged in PR ouroboros-consensus#1288 - do not expose `HeaderWithTime` in `TraceGDDEvent` via `GDDDebugInfo` - do not store the chain fragment with `HeaderWithTime` in `DensityBounds`
geo2a
force-pushed
the
geo2a/header-with-time-followup
branch
from
1797e4f to
5e519ff
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a follow-up to #1288 that ensures
HeaderWithTimeinTraceGDDEventviaGDDDebugInfoHeaderWithTimeinDensityBoundsadding the "no changelog'' label, as the relevant changelog fragments are already included into "main"
Draft PR to for integration with the node: IntersectMBO/cardano-node#6211