Introduce fourmolu
#1500
Open
Introduce fourmolu
#1500
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
geo2a
force-pushed
the
geo2a/issue-1499-introduce-fourmolu
branch
4 times, most recently
from
f02fd29 to
bcd85b6
Compare
geo2a
force-pushed
the
geo2a/issue-1499-introduce-fourmolu
branch
7 times, most recently
from
8b917de to
3d236c7
Compare
geo2a
requested review from
nfrisby,
jasagredo,
amesgen,
fraser-iohk,
dnadales and
jorisdral
as code owners
amesgen
reviewed
May 13, 2025
| @@ -0,0 +1,6 @@ | |||
| indentation: 2 | |||
| column-limit: 100 | |||
There was a problem hiding this comment.
Enforcing a column limit has various idempotency issues. Usually minor, so no need to do sth immediately, but something to keep in mind if it gets too annoying.
There was a problem hiding this comment.
Would you rather suggest to reformat the code base and to not enforce the limit? I do not see how we would be able to prevent addition of longer lines in this case.
There was a problem hiding this comment.
No, what you do in this PR looks good to me, just pointing out this potential downside of column-limit, but no immediate action required.
...consensus/src/ouroboros-consensus/Ouroboros/Consensus/Storage/ImmutableDB/Chunks/Internal.hs
Outdated
Show resolved
Hide resolved
- enable ImportQualifiedPost - apply fourmolu code styler to all files
Allows ignoring code reformatting and similar changes
geo2a
force-pushed
the
geo2a/issue-1499-introduce-fourmolu
branch
from
3d236c7 to
1efcc78
Compare
geo2a
force-pushed
the
geo2a/issue-1499-introduce-fourmolu
branch
from
4c93d83 to
03f535a
Compare
jasagredo
approved these changes
May 15, 2025
| @@ -203,19 +203,19 @@ and improvements are always welcome. | |||
|
|
|||
| ## Formatting the code | |||
|
|
|||
| We use `stylish-haskell` 0.14.6.0 for Haskell code formatting. | |||
| We use `fourmolu` 0.17.0.0 for Haskell code formatting. | |||
There was a problem hiding this comment.
It is 0.18.0.0 in the end.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #1499
PR description
This PR introduces
fourmoluas an automatic code formatter to replacestylish-haskellBeyond the actual reformatting, I've introduced the following changes:
fourmoluto the Nix shellscripts/ci/run-fourmolu.shscripts, which is based on the previously used script forstylish-haskellfourmolu(and pushed a dummy commit to check that the CI rejects improperly styled code).git-blame-ignore-revsand checked that the blame interface on GitHub respects itfourmolu.Additionally, I've enabled
ImportQualifiedPostin all cabal files, alongside with the-Wprepositive-qualified-modulewarning. This extension and warning could be removed once (if?) we transition toGHC2021as the default language.