Resurrect UTxO statistics in LSM-trees #1810
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jasagredo
requested review from
bladyjoker,
dnadales,
fraser-iohk,
geo2a and
nfrisby
as code owners
bladyjoker
reviewed
Dec 17, 2025
| Diff.Insert{} -> True | ||
| Diff.Delete -> False | ||
| ) | ||
| diffs |
Contributor
There was a problem hiding this comment.
You're iterating over diffs in the loop above, consider making these calculations there.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
LSM-trees has no way to easily tell the number of entries in a table. With this PR we keep a counter that we modify as we push differences to the tables.
This was requested by the Performance and Tracing team.