More consistent traces between immdb-server and cardano-node #1812
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This uses the same amount of information as was available on the patched cardano-node. The conversion function messageLeiosFetchToObject is now also re-used across all 3 call sites.
ch1bo
requested review from
amesgen,
dnadales,
fraser-iohk,
geo2a,
jasagredo,
jorisdral and
nfrisby
as code owners
This was referenced Dec 16, 2025
Closed
bladyjoker
approved these changes
Dec 17, 2025
| , direction :: Direction | ||
| , msg :: String | ||
| , direction :: Direction | ||
| , msg :: Aeson.Value |
Contributor
There was a problem hiding this comment.
Not sure why this isn't a type var msg with Aeson.(To|From)Object msg instances? But not really important at this point.
Author
There was a problem hiding this comment.
We'd only be able to constrain the variable on the creation/processing, or you mean to make it an existential?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Aligns
MsgLeiosBlockandMsgBlocktraces between patchedimmdb-serverandcardano-nodesuch that both have similar contents and at least contain block hashes.