Skip to content

Fix waiting on all miniprotocols #5118

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Draft
wants to merge 1 commit into
base: release/ouroboros-network-0.20
Choose a base branch
from
Draft

Fix waiting on all miniprotocols #5118

wants to merge 1 commit into from

Conversation

karknu
Copy link
Contributor

@karknu karknu commented May 6, 2025 •
edited
Loading

Description

Fix awaitAllResults so that it really waits for miniprotocols to finish.

Checklist

Quality

  • Commit sequence makes sense and have useful messages, see ref.
  • New tests are added and existing tests are updated.
  • Self-reviewed the PR.

Maintenance

  • Linked an issue or added the PR to the current sprint of ouroboros-network project.
  • Added labels.
  • Updated changelog files.
  • The documentation has been properly updated, see ref.

@karknu
Fix awaitAllResults
be28257 
Fix awaitAllResults so that it waits for miniprotocols that hasn't
finished yet.
@github-project-automation github-project-automation bot moved this to In Progress in Ouroboros Network May 6, 2025
@karknu karknu changed the base branch from main to release/ouroboros-network-0.20 May 6, 2025 05:17
@karknu karknu changed the title Karknu/really await all Fix waiting on all miniprotocols May 6, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
Ouroboros Network
Status: In Progress
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@karknu