BRD-1042-Emit-productType-as-separate-locale-aware-field#69
Merged
Conversation
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
There was a problem hiding this comment.
Code Review
This pull request decouples Shopify's Standard Product Taxonomy from the legacy product type field, introducing a standalone productType attribute and removing the previous fallback logic for categoryDefault. Review feedback identifies this as a potential regression that could break search UI features like breadcrumbs and categorization. The reviewer recommends restoring the fallback for categoryDefault and ensuring that localized productType fields fall back to the primary locale's value when translations are unavailable.
tomas862
approved these changes
May 11, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Stops folding productType into categoryDefault as a fallback — emits it as its own productType_ field with proper per-locale translation lookup. Fixes the case where Shopify Standard Taxonomy (English-only) was masking a translated productType value, leaving non-English storefronts with English category labels.
BRD-1042