Skip to content

Responsive Navbar and Hero Section #6

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
bhaveyx merged 3 commits into from
Oct 25, 2021
Merged

Responsive Navbar and Hero Section #6

bhaveyx merged 3 commits into from
Oct 25, 2021

Conversation

@bhaveyx
Copy link
Member

@bhaveyx bhaveyx commented Oct 25, 2021 •
edited
Loading

Description

  1. Made Navbar and Hero Section Responsive.
  2. Replaced the window.onscroll approach with Intersection Observer Api approach for better accuracy.

Type of Change

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)

Checklist:

  • My code follows the style guidelines of this project
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • My changes generate no new warnings

@bhaveyx bhaveyx changed the title Bhavesh Responsive Navbar and Hero Section Oct 25, 2021
@bhaveyx bhaveyx merged commit a27cf61 into main Oct 25, 2021
@bhaveyx bhaveyx added the enhancement New feature or request label Oct 25, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

enhancement New feature or request

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@bhaveyx @PrateekPheonix