EI-3331 - chore: Bump cryptography to 43.0.1 #21
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Bumping patch version despite slight incompatibilities between 42.0.8 & 43.0.1 of cryptography since the SSL version mentioned therein was released a long time ago (03/2020)
vtermanis
commented
Sep 24, 2024
| @@ -18,7 +18,7 @@ max-complexity = 15 | |||
|
|
|||
| [metadata] | |||
| name = iotics-identity | |||
| version = 2.1.1 | |||
| version = 2.1.2 | |||
There was a problem hiding this comment.
See commit comment regarding reasoning around patch vs minor increment. Also:
vtermanis
force-pushed
the
ei-3331-security-deps
branch
from
5472889 to
2d92f83
Compare
- Switch to shields.io
vtermanis
force-pushed
the
ei-3331-security-deps
branch
from
2d92f83 to
ece1d24
Compare
- Switch email address - Remove outdated Python version, add current ones (to classifiers)
vtermanis
commented
Sep 24, 2024
| @@ -1,9 +1,8 @@ | |||
| # iotics-identity-py | |||
|
|
|||
| [](https://pypi.org/project/iotics-identity/) | |||
There was a problem hiding this comment.
These no longer worked
|
any chance you could make a slight update to the readme instruction for |
conbon
approved these changes
Sep 24, 2024
- Use single quotes for maximum compatibility with shells (e.g. zsh) - Specify '-e' for development-mode install
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Sanity performance results attached to ticket - looks OK.