Make lock object in ControlFlowInstructions.Compile private#287
Merged
slozier merged 1 commit intoIronLanguages:mainfrom Feb 20, 2026
Merged
Make lock object in ControlFlowInstructions.Compile private#287slozier merged 1 commit intoIronLanguages:mainfrom
slozier merged 1 commit intoIronLanguages:mainfrom
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Using
lock (this)exposes the lock to external callers. If it is meant to be used internally, it should be locking on a private object. If it is used as a part of public (or protected) API, it should be documented explicitly, because it is not visible from just looking at the public/protected methods. Also, locking onthisdoes not allow for different choice of type for the lock object, so generally is not a good idea.ControlFlowInstructionsuses it only for private purpose, to ensure it is compiled only once. This PR fixes that locking.Unfortunately,
CustomStringDictionaryalso doeslock (this), but it is a public abstract class, so lockingthisis already part of the established public usage spec of this class and changing it would be a breaking API change. ThereforeCustomStringDictionaryis not changed.