Merged
Conversation
Contributor
Author
|
@pepyakin adding you because I added copyright notices everywhere |
Contributor
Author
|
@fkondej something weird happened while I was merging master/main; all the ci/license changes ended up in this PR; are you ok with this? scratch that, rebased |
lockedloop
force-pushed
the
danilo/remove-setup-from-benchmarking-loops
branch
from
a6d5912 to
a79e957
Compare
paulcadman
approved these changes
Sep 10, 2025
Contributor
paulcadman
left a comment
paulcadman
left a comment
There was a problem hiding this comment.
I can run the CPU benchmarks locally ✅
Before merging can you squash all the commits? Or use the "Squash and merge" option when merging in GitHub to tidy the intermediate broken commits?
Contributor
Author
|
In HW we always used squash + merge. I like it. |
jimpo
approved these changes
Sep 10, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.