Merged
Conversation
There was a problem hiding this comment.
Pull request overview
This pull request adds a comprehensive CSV interface for reading and writing columnar data. It removes placeholder "add" functionality and introduces a complete data structure foundation including schemas, fields, columns, and batches with CSV serialization support.
Changes:
- Implemented CSV parsing with support for quoted fields, custom delimiters, and configurable batch sizes
- Added core columnar data structures (Schema, Field, Column types, Batch) with nullable support
- Replaced placeholder "add" functionality with production CSV I/O capabilities
Reviewed changes
Copilot reviewed 29 out of 32 changed files in this pull request and generated 15 comments.
Show a summary per file
| File | Description |
|---|---|
| tests/test_csv.cpp | Comprehensive test suite for CSV reading/writing, schema management, and error cases |
| tests/test_bruh.cpp | Removed placeholder test file |
| tests/CMakeLists.txt | Updated to use new CSV tests |
| src/core/column.cpp | Factory function for creating typed columns |
| src/add.cpp | Removed placeholder implementation |
| include/util/parse.h | Generic string parsing utilities for various types |
| include/util/macro.h | Error handling and assertion macros |
| include/csv/schema_reader.h | Schema serialization to/from CSV format |
| include/csv/csv_row_reader.h | Low-level CSV row parsing with quote handling |
| include/csv/csv_options.h | Configuration options for CSV parsing/writing |
| include/csv/csv_batch_writer.h | Batch-oriented CSV writer with automatic quoting |
| include/csv/csv_batch_reader.h | Batch-oriented CSV reader with type conversion |
| include/csv/csv.h | Umbrella header for CSV functionality |
| include/core/schema.h | Schema definition with field lookup |
| include/core/field.h | Field metadata (name, type, nullable) |
| include/core/datatype.h | Data type enumeration and conversion utilities |
| include/core/columns/string_column.h | String column implementation |
| include/core/columns/numeric_column.h | Template for numeric column types |
| include/core/columns/abstract_column.h | Abstract column interface |
| include/core/column.h | Column type aliases and factory |
| include/core/batch_writer.h | Abstract batch writer interface |
| include/core/batch_reader.h | Abstract batch reader interface |
| include/core/batch.h | Batch container for columnar data |
| include/columnar/add.h | Removed placeholder header |
| benchmarks/bench_csv.cpp | Performance benchmarks for CSV operations |
| benchmarks/bench_bruh.cpp | Removed placeholder benchmark |
| benchmarks/CMakeLists.txt | Updated to use CSV benchmarks |
| apps/converter/main.cpp | Temporarily disabled converter functionality |
| CMakeLists.txt | Updated library sources and include path |
| .gitignore | Added .clangd to ignore list |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
There was a problem hiding this comment.
Pull request overview
Copilot reviewed 30 out of 33 changed files in this pull request and generated 16 comments.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.