Skip to content

- Fix the trigger "auto-drop" function (the trigger drop needs to be …#215

Open
darkag wants to merge 1 commit into
IsNemoEqualTrue:masterfrom
darkag:master
Open

- Fix the trigger "auto-drop" function (the trigger drop needs to be …#215
darkag wants to merge 1 commit into
IsNemoEqualTrue:masterfrom
darkag:master

Conversation

@darkag

@darkag darkag commented Oct 16, 2020

Copy link
Copy Markdown

…the last operation before return)

  • Fix incorrect WaitForNotifications start that prevent stop to termitate if stoped on application closing (wrong task was waited)

…the last operation before return)

- Fix incorrect WaitForNotifications start that prevent stop to termitate if stoped on application closing (wrong task was waited)
@SteffeyDev

Copy link
Copy Markdown

Before making this change, did you experience orphaned triggers in SQL that were causing problems?

@darkag

darkag commented Oct 31, 2020

Copy link
Copy Markdown
Author

Yes that's why I started to look in the source code. When the problem occured I was not able to update the watched table since the trigger drop command failed.

I got error messages like the ones described in issue #214 or #188.

@SteffeyDev

Copy link
Copy Markdown

Have you run your version of the code in production for some time without issues? We are seeing the same issues

@darkag

darkag commented Nov 2, 2020

Copy link
Copy Markdown
Author

Yes, no problems since the corrections I've made.

@lekrus

lekrus commented Dec 16, 2020

Copy link
Copy Markdown

unfortunately this fix didn't work for me: had issues with stopping listener and also it was not possible to do a restart after an error, something is wrong with changes to WaitForNotifications await

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants