Skip to content

Improve the ServiceBrokerNotEnabledException message #223

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
0xced wants to merge 2 commits into
base: master
Choose a base branch
from
Open

Improve the ServiceBrokerNotEnabledException message #223

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
ea81c1e
Improve the ServiceBrokerNotEnabledException message
0xced Jan 11, 2021
810c979
Include "WITH ROLLBACK IMMEDIATE" in the command for enabling the broker
0xced Jan 11, 2021
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 5 additions & 1 deletion TableDependency.SqlClient/Exceptions/ServiceBrokerNotEnabledException.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -31,7 +31,11 @@ namespace TableDependency.SqlClient.Exceptions
public class ServiceBrokerNotEnabledException : TableDependencyException
{
protected internal ServiceBrokerNotEnabledException()
: base("Service broker not enable. Please activete it using 'ALTER DATABASE MyDatabase SET ENABLE_BROKER' command.")
: this("MyDatabase")
{ }

protected internal ServiceBrokerNotEnabledException(string database)
: base($"Service broker is not enabled. Please activate it using 'ALTER DATABASE {database} SET ENABLE_BROKER WITH ROLLBACK IMMEDIATE' command.")
{ }
}
}
18 changes: 17 additions & 1 deletion TableDependency.SqlClient/SqlTableDependency.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -971,7 +971,23 @@ protected virtual void CheckIfServiceBrokerIsEnabled()
using (var sqlCommand = sqlConnection.CreateCommand())
{
sqlCommand.CommandText = "SELECT is_broker_enabled FROM sys.databases WITH (NOLOCK) WHERE database_id = db_id();";
if ((bool)sqlCommand.ExecuteScalar() == false) throw new ServiceBrokerNotEnabledException();
if ((bool)sqlCommand.ExecuteScalar() == false)
{
string database;
try
{
database = new SqlConnectionStringBuilder(_connectionString).InitialCatalog;
}
catch
{
database = null;
}
if (!string.IsNullOrEmpty(database))
{
throw new ServiceBrokerNotEnabledException(database);
}
throw new ServiceBrokerNotEnabledException();
}
}
}
}
Expand Down