Skip to content

Comments

bump alpine to 3.20.6 and build apk packages in this repo#425

Merged
nigelgbanks merged 11 commits intomainfrom
mono-repo
May 13, 2025
Merged

bump alpine to 3.20.6 and build apk packages in this repo#425
nigelgbanks merged 11 commits intomainfrom
mono-repo

Conversation

@joecorall
Copy link
Contributor

@joecorall joecorall commented May 6, 2025

With #423 we now can build images faster in GitHub Actions.

So basically cloned two repos we have that build apk packages into their own directories in this repo

Then updated docker-bake.hcl and our GHA to build those images.

@joecorall joecorall force-pushed the mono-repo branch 4 times, most recently from db2490c to 63193f2 Compare May 6, 2025 16:30
@joecorall joecorall changed the title Bring in apk repos [minor] bring in apk repos May 6, 2025
@joecorall joecorall changed the title [minor] bring in apk repos bring in apk repos May 6, 2025
@joecorall joecorall changed the title bring in apk repos build apk packages in this repo May 7, 2025
@joecorall joecorall marked this pull request as ready for review May 7, 2025 04:14
@joecorall joecorall marked this pull request as draft May 7, 2025 14:22
@joecorall joecorall marked this pull request as ready for review May 12, 2025 15:49
@joecorall
Copy link
Contributor Author

@nigelgbanks - if we were to do this, do you think nodejs would only trigger a rebuild (which takes ~2h) when something in the image gets bumped?

@nigelgbanks
Copy link
Contributor

@joecorall yup it would, perhaps it's time to drop code-server? We should make a post on slack to see if it's actively used?

@nigelgbanks
Copy link
Contributor

The caching is a bit hit or miss currently, I'm actively trying some new features to get it to be better. That being said, GitHub only has a local cache of 10GB for the whole repo (not per branch), and the image cache on docker hub doesn't capture the c++ compilation, it's only cached locally. So any time it needs to rebuild it will take forever.

@nigelgbanks
Copy link
Contributor

@joecorall joecorall changed the title build apk packages in this repo bump alpine to 3.20.6 and build apk packages in this repo May 12, 2025
@joecorall
Copy link
Contributor Author

While we decide the future of code-server I went ahead and dropped nodejs from this PR to avoid the long build times. We maybe could just keep nodejs as-is in a separate repo. I suspect if we dropped codeserver that will take a lot of effort around documentation, isle-site-template, isle-dc, etc.

@nigelgbanks
Copy link
Contributor

So far, the slack makes it look like no one uses it 🤷

@joecorall
Copy link
Contributor Author

joecorall commented May 12, 2025

If we do end up removing it, which looks like we will, that will probably involve a bit of work Islandora/documentation#2361

i don't think that work needs to block this PR

@nigelgbanks nigelgbanks merged commit 956f750 into main May 13, 2025
253 of 255 checks passed
@nigelgbanks nigelgbanks deleted the mono-repo branch May 13, 2025 06:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants