[major] replace crayfish derivative microservices with scyllaridae#432
Merged
nigelgbanks merged 20 commits intomainfrom Oct 11, 2025
Merged
[major] replace crayfish derivative microservices with scyllaridae#432nigelgbanks merged 20 commits intomainfrom
nigelgbanks merged 20 commits intomainfrom
Conversation
nigelgbanks
requested changes
Oct 9, 2025
Contributor
nigelgbanks
left a comment
There was a problem hiding this comment.
Other than the one change, this looks good to go in, great work!!!
Contributor
Author
|
gonna add some integration tests |
f74469a to
b366d1d
Compare
b366d1d to
6e18c8a
Compare
We aren't testing FITS functionality in this test per-say so using the latest version should be fine
the test runs fine locally. It's probably our simplest scyllaridae microservice so we probably don't need to test this
nigelgbanks
requested changes
Oct 10, 2025
Contributor
nigelgbanks
left a comment
There was a problem hiding this comment.
Still just the issue with scyllaridae/rootfs/etc/s6-overlay/s6-rc.d/scyllaridae/dependencies.d/container-environment but otherwise great! Awesome to have the tests!
f6de527 to
7c03a82
Compare
nigelgbanks
approved these changes
Oct 11, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Replace crayfish derivative microservices with scyllaridae.
As seen in this PR and Islandora/Crayfish#188, scyllaridae offers significantly less code complexity to add new microservices. Between this PR and Islandora/Crayfish#188 around 40K lines of code can be removed by replacing crayfish with scyllaridae. scyllaridae is basically an http service with a YAML based spec to define how derivatives are created when events are received by the service. This allows for new microserves to easily be created by only focusing on the input file source, what software needs to manipulate the input, and then printing the resulting file to stdout. Islandora's specifics around JWT auth, how the source file is streamed, and how the output is streamed, are all handled by the core scyllaridae service, and the spec is how individual microservices can implement their specific logic.
Some reasoning why this PR was created:
If there is interest in this, we can build a milliner alternative using scyllaridae and remove crayfish algother from buildkit.
Related to Islandora/documentation#2354 Islandora/Crayfish#188