Merged
Conversation
Contributor
Author
|
@chryslovelace can you check this out? I made some changes. |
joecorall
approved these changes
Jun 29, 2025
Contributor
There was a problem hiding this comment.
LGTM. I added a push GHA with fe495f5 so we can easily test this with the docker image islandora/transkribus:transkribus-fixes. I can test this week once I sign up for transkribus to get a test account. Though if @chryslovelace confirms this is working before I can get to it, lets merge.
Contributor
Author
|
@joecorall thanks for catching that! |
|
Just tested and can confirm that it's working. |
joecorall
requested changes
Jun 30, 2025
Contributor
joecorall
left a comment
joecorall
left a comment
There was a problem hiding this comment.
great! Let's just get the CI test working then I think we can merge this
Contributor
Author
|
@joecorall I'll sort the test now |
joecorall
approved these changes
Jun 30, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Replaces #435