Add full event as base 64 encoded X-Islandora-Event header#94
Add full event as base 64 encoded X-Islandora-Event header#94aOelschlager merged 5 commits into2.xfrom
Conversation
|
relates to Islandora-Labs/rfds#1 |
|
Wondering if it might be easier to add the |
|
@whikloj - do you see something wrong with the proposed changes in this PR? The change here seem small enough I think since the work is mostly done the clearest path may be to merge this PR after it's tested successfully. |
|
I don't see anything wrong specifically, you might want a |
It's just a bit of pragmatism. Right now changing alpaca will allow this new class of microservices that need this data to work for everyone. If we sent this new header from Drupal we'd need some other way to propogate the header to the respective microservice rather than going through the current happy path of drupal->activemq->alpaca->microservice. |
...r-derivative/src/main/java/ca/islandora/alpaca/connector/derivative/DerivativeConnector.java
Outdated
Show resolved
Hide resolved
...r-derivative/src/main/java/ca/islandora/alpaca/connector/derivative/DerivativeConnector.java
Show resolved
Hide resolved
5f633f3 to
87bf621
Compare
…ca/connector/derivative/DerivativeConnector.java
7462a9f to
7119725
Compare
|
I know this isnt the right place for this but I am looking to alter our tesseract actor to build hOCR and OCR at the same time. Perhaps we need a specification for the messages we are sending, then it would be easier to ensure all clients (I.e. Alpaca, etc) can handle all cases. |
adam-vessey
left a comment
There was a problem hiding this comment.
Couple of tiny coding standards things.
...r-derivative/src/main/java/ca/islandora/alpaca/connector/derivative/DerivativeConnector.java
Outdated
Show resolved
Hide resolved
...r-derivative/src/main/java/ca/islandora/alpaca/connector/derivative/DerivativeConnector.java
Outdated
Show resolved
Hide resolved
Co-authored-by: Adam <607975+adam-vessey@users.noreply.github.com>
…ca/connector/derivative/DerivativeConnector.java Co-authored-by: Adam <607975+adam-vessey@users.noreply.github.com>
Let's have this conversation in Islandora-Labs/rfds#1 |
aOelschlager
left a comment
There was a problem hiding this comment.
I tested this pr with Joe's buildkit pr and it works! I was able to generate derivatives including the merge pdf derivatives.
* Build alpaca JAR * checkout Islandora/Alpaca#94 * fix build * Use image with git installed * Add merge PDF * update README * Update README * term_from_term_name route is protected by auth * Update README with jwt_auth requirement Added requirement for jwt_auth in term_from_term_name view. * Update push.yml * Enable MERGEPDF in Dockerfile * Added URL decoding for '%' characters in URLs. * Make the drupal URI configurable * standardize alpaca install with scyllaridae pattern * use base to access download.sh --------- Co-authored-by: Seth Shaw <108362375+seth-shaw-asu@users.noreply.github.com>
GitHub Issue: Event RFD (0000)
What does this Pull Request do?
Add the complete event JSON as an
X-Islandora-EventHTTP header when calling microservicesHow should this be tested?
🤷♂️ - throwing this up here for now; but I'm guessing we need to
The resulting alpaca build is too big for GitHub to permit me to attach it here. So, to build it yourself only using docker (no Java or Gradle required):
docker run --rm -v "$(pwd):/app" -w /app eclipse-temurin:11 ./gradlew --stacktrace clean build shadowJar --no-daemon.The resulting Jar file you need will be @
islandora-alpaca-app/build/libs/islandora-alpaca-*-all.jarInterested parties
@Islandora/committers, esp @joecorall