[major] Upgrade Milliner to PHP 8.4 and Symfony 8.1 - #191
Open
joecorall wants to merge 6 commits into
Open
Conversation
joecorall
marked this pull request as ready for review
July 22, 2026 16:56
joecorall
marked this pull request as draft
July 22, 2026 17:08
Add trustworthy service tests, real Fcrepo6 and site-template lifecycle lanes, and fix authorization, JSON-LD URL handling, and media-version validation uncovered by them.
Remove the broken Codecov upload and build the site-template test image from the published PHP 8.4 runtime so application CI is independent of Alpine package-pin churn.
joecorall
force-pushed
the
php-8.4-symfony-8.1
branch
from
July 29, 2026 14:53
b02435b to
71504a7
Compare
joecorall
force-pushed
the
php-8.4-symfony-8.1
branch
from
July 29, 2026 15:02
71504a7 to
1a4fbe7
Compare
joecorall
marked this pull request as ready for review
July 29, 2026 15:08
aOelschlager
self-requested a review
July 29, 2026 15:37
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What does this Pull Request do?
Upgrades Milliner—the supported application in Crayfish—to PHP 8.4.1+ and Symfony 8.1. This modernizes its runtime, dependencies, configuration, and test infrastructure while preserving its Drupal-to-Fedora behavior and aligning it with the Alpine 3.24 container line.
CrayFits, Homarus, Houdini, Hypercube, and Recast are deprecated and are not ported as part of this change.
What's new?
composer.lock, and upgrades the development stack to PHPUnit 12.5 and Symfony PHPUnit Bridge 8.1._format=jsonld, missingContent-Locationhandling, invalid JSON-LD resource URLs/graphs, and invalid modified dates.islandora/fcrepo6:maincovering create, update, version, and delete operations.composer coverage.Documentation is updated in this PR. Existing deployments must move to PHP 8.4.1+ (or the corresponding new Milliner container) before adopting this release. The deprecated Crayfish applications remain in the repository but are not upgraded or exercised by the current Milliner CI.
How should this be tested?
Run the local validation and unit suite:
The expected unit result is 49 tests and 111 assertions.
The pull request should also have all three CI jobs passing:
PHP 8.4validates Composer, audits the lock file, checks PSR-2 formatting, and runs the unit suite.Fcrepo6 main contractruns Milliner's focused lifecycle contract againstislandora/fcrepo6:main.Drupal to Fcrepo6 lifecyclestarts the pinnedisle-site-templatestack with the Milliner source from this PR, then runs the PHPUnit lifecycle test inside the CI Milliner container.Additional Notes:
Coordinated pull requests:
Recommended merge/pin order:
Interested parties
@Islandora/8-x-committers