Fix for Issues/95 - #96
Open
kylehuynh205 wants to merge 4 commits into
Open
Conversation
Reset the URL after the reset button is clicked to address issue Islandora#95.
joecorall
self-requested a review
June 17, 2026 17:07
joecorall
requested changes
Jun 26, 2026
joecorall
left a comment
joecorall
left a comment
Member
There was a problem hiding this comment.
I think this should use URL / URLSearchParams instead of manually checking for ? and concatenating query params. The current fix handles the immediate missing ? case, but it might still produce bad URLs in edge cases and duplicate params.
Also, the reset handler calls both pushState() and location.replace();. Since replace() navigates immediately, what does adding pushState() do? Can we either remove the forced navigation or use URL parsing to clear the query string safely?
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What does this Pull Request do?
Fix for the issue #95
Related GitHub Issue: (link)
Other Relevant Links: (Google Groups discussion, related pull requests,
Release pull requests, etc.)
What's new?
Add a check if missing "?" for the based url before update the links in Item per Page and Display mode