Skip to content

Conversation

@bboro
Copy link

@bboro bboro commented Jan 16, 2026

What does this Pull Request do?

Fixes error after updating to Drupal core 11.3:

PHP Fatal error:  Cannot redeclare readonly property Drupal\Core\Entity\Controller\EntityController::$entityTypeManager as non-readonly Drupal\islandora\Controller\ManageMembersController::$entityTypeManager in /var/www/html/web/modules/contrib/islandora/src/Controller/ManageMembersController.php on line 18

What's new?

  • Adds call to parent::__construct() from ManageMembersController::__construct() which wasn't there before.
  • Updated dependency injections and constructor of ManageMembersController to include dependencies required by the EntityController parent constructor.
  • Auto assigned properties from ManageMembersController constructor, and removed explicit property declarations in ManageMembersController.
  • Does this change add any new dependencies?
    • No
  • Does this change require any other modifications to be made to the repository
    (i.e. Regeneration activity, etc.)?
    • No
  • Could this change impact execution of existing code?
    • No, it seems nothing's instantiating ManageMembersController manually, except from the router.

How should this be tested?

A description of what steps someone could take to:

  • Reproduce the problem you are fixing (if applicable)
    • Install Drupal 11.3 with Islandora 2.17.3 and try to cache clear via drush. This produces the fatal error mentioned above.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant