Skip to content

Bugfix: event's stream_version can overflow when inserting it in Postgres #3

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
Istar-Eldritch merged 2 commits into from
Jan 21, 2026
Merged

Bugfix: event's stream_version can overflow when inserting it in Postgres #3

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
e2276d3
Add fix and test
jpcano Oct 14, 2025
c26d20b
Merge branch 'main' into bugfix-version-pg-overflow
jpcano Jan 21, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 6 additions & 1 deletion epoch_pg/src/event_store.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -213,7 +213,12 @@ where
)
.bind(event.id)
.bind(event.stream_id)
.bind(event.stream_version as i64)
.bind(TryInto::<i64>::try_into(event.stream_version).map_err(|e| {
PgEventStoreError::DBError(sqlx::error::Error::InvalidArgument(format!(
"stream_version {} is too large to fit in i64: {}",
event.stream_version, e
)))
})?)
.bind(event.event_type.to_string())
.bind(
event
Expand Down
18 changes: 17 additions & 1 deletion epoch_pg/tests/pgeventstore_integration_tests.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -50,8 +50,24 @@ async fn test_store_event() {
}))
.build()
.unwrap();

event_store.store_event(event.clone()).await.unwrap();

let event_overflow = Event::<TestEventData>::builder()
.id(Uuid::new_v4())
.stream_id(Uuid::new_v4())
.stream_version(u64::MAX)
.event_type("TestEvent".to_string())
.data(Some(TestEventData::TestEvent {
value: "test_overflow".to_string(),
}))
.build()
.unwrap();
assert!(matches!(
event_store.store_event(event_overflow.clone()).await,
Err(epoch_pg::event_store::PgEventStoreError::DBError(
sqlx::error::Error::InvalidArgument(_)
))
));
teardown(&pool).await;
}

Expand Down