Skip to content

Update build.yml #728

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 2 commits into
base: main
Choose a base branch
from
Open

Update build.yml #728

wants to merge 2 commits into from

Conversation

theely
Copy link

@theely theely commented Jul 18, 2024

Builds Python binding on MacOS ARM
Relates to: #726

Builds Python binding on MacOS ARM
@Kobzol
Copy link
Collaborator

Kobzol commented Jul 18, 2024

Hi, thanks for the PR! I'm still a bit uneasy about providing these packages when we officially don't support them 😅, but I guess there's no harm in doing that when we explicitly state that it's a best effort approach.

It looks like HQ_BUILD_VERSION is not propagated into maturin, probably because it is set using docker-options, and Docker isn't used on macOS for the maturin build. Could you try adding HQ_BUILD_VERSION: ${{ needs.set-env.outputs.version }} here?

Added missing env
@Kobzol
Copy link
Collaborator

Kobzol commented Jul 19, 2024

Right, so the macOS Python package was built, but most of the Python API tests (expectedly) fail with it. I'm really unsure whether we want to release packages are unsupported and also fail most tests, especially when interested users can just build the package locally.. @spirali What do you think?

@theely
Copy link
Author

theely commented Jul 19, 2024

Indeed this is less than ideal. Conceptually it makes sense to provide client libs (Python package) built for multiple architectures even if the server binary only runs on x64.
Unfortunately, I don't see a way to build a client on one architecture and test it against a server running on a different one.

@Kobzol
Copy link
Collaborator

Kobzol commented Jul 19, 2024

The client should probably work on macOS (not 100% sure though), so it is a valid use-case (although most HQ users just run the client on a supercomputer). But as you said, providing testing of a macOS client and e.g. a Linux/x64 server/worker is highly non-trivial and we do not have the necessary testing infrastructure prepared for that.

@spirali
Copy link
Collaborator

spirali commented Jul 21, 2024

I like the idea that we are distributing MacOs client, but without at least partial automatic testing it is quite thin ice and it will be broken somewhere in the future.

Does GitHub CI allow something like docker compose? So we can start linux & macos instance together? Or can be we start linux docker container inside a macos CI instance?

@Kobzol
Copy link
Collaborator

Kobzol commented Jul 21, 2024

Starting a (virtualized) Linux Docker container inside a macOS is probably possible, but I'm not sure if that works on GitHub Actions, I didn't find much information about it online.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants