-
Notifications
You must be signed in to change notification settings - Fork 30
Update build.yml #728
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Update build.yml #728
Conversation
Builds Python binding on MacOS ARM
Hi, thanks for the PR! I'm still a bit uneasy about providing these packages when we officially don't support them 😅, but I guess there's no harm in doing that when we explicitly state that it's a best effort approach. It looks like |
Added missing env
Right, so the macOS Python package was built, but most of the Python API tests (expectedly) fail with it. I'm really unsure whether we want to release packages are unsupported and also fail most tests, especially when interested users can just build the package locally.. @spirali What do you think? |
Indeed this is less than ideal. Conceptually it makes sense to provide client libs (Python package) built for multiple architectures even if the server binary only runs on x64. |
The client should probably work on macOS (not 100% sure though), so it is a valid use-case (although most HQ users just run the client on a supercomputer). But as you said, providing testing of a macOS client and e.g. a Linux/x64 server/worker is highly non-trivial and we do not have the necessary testing infrastructure prepared for that. |
I like the idea that we are distributing MacOs client, but without at least partial automatic testing it is quite thin ice and it will be broken somewhere in the future. Does GitHub CI allow something like docker compose? So we can start linux & macos instance together? Or can be we start linux docker container inside a macos CI instance? |
Starting a (virtualized) Linux Docker container inside a macOS is probably possible, but I'm not sure if that works on GitHub Actions, I didn't find much information about it online. |
Builds Python binding on MacOS ARM
Relates to: #726