Feat: Add empty json output mode #844
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Kobzol
reviewed
Mar 8, 2025
There was a problem hiding this comment.
Hi, thanks for the PR! The {} should be only printed for the JSON printer, for the normal printer there's no point in printing an additional empty line.
Actually, it should be easy to solve this fully generally for all commands with this approach:
- Remember in the JSON printer if anything was printed.
- Add a
finalize_outputfunction to the printer, which will be called just before HQ exits (even if an error has occurred). - Implement
finalize_outputfor the JSON printer in a way where it will output{}if nothing was previously printed.
|
my apologies for the late reply, I am currently writing exams, I will be done next week and pick this up. Thanks! |
…nto feat/empty-json-output-mode
Signed-off-by: tdadadavid <[email protected]>
Kobzol
reviewed
Apr 22, 2025
| @@ -251,6 +251,10 @@ impl Output for JsonOutput { | |||
| fn print_error(&self, error: Error) { | |||
| self.print(json!({ "error": format!("{error:?}") })) | |||
| } | |||
|
|
|||
| fn finalize_output(&self) { | |||
| self.print(json!({})); | |||
There was a problem hiding this comment.
This should only be printed if we did not print anything in the JSON printer. Otherwise we will print multiple JSON objects, which is invalid JSON.
There was a problem hiding this comment.
Ohh thanks I will work on this now.
| @@ -1034,6 +1034,10 @@ impl Output for CliOutput { | |||
| job_id.to_string().color(colored::Color::Green), | |||
| ); | |||
| } | |||
|
|
|||
| fn finalize_output(&self) { | |||
| println!() | |||
There was a problem hiding this comment.
We don't need to print anything here.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
[✅] Add
print_emptyto theOutputtrait[✅] Implemented
print_emptyforJSON,CliandQuietFor #830