Mob 11167 fix anr renaming config #902
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Internal working of Keychain at this commit stage still assumes the default is false. Hence this commit cant be merged as IterableConfig and Keychain work on different basis
Inverting the defaults for easy naming. Modified the Test suite as well to be aware of defaults.
There was a problem hiding this comment.
Copilot reviewed 5 out of 5 changed files in this pull request and generated no comments.
Comments suppressed due to low confidence (1)
iterableapi/src/main/java/com/iterable/iterableapi/IterableConfig.java:317
- [nitpick] The parameter documentation still refers to disabling encryption while the flag now indicates that encryption is enabled when true. Please update the comment to accurately reflect that keychainEncryption = true means encryption is enabled.
* @param keychainEncryption Whether to disable encryption for keychain
sumeruchat
approved these changes
Apr 14, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
TOP - UP PR for suggested naming inversion.
@sumeruchat Please check if the Test modification makes sense.