SDK-15 🧪 Embedded Messaging integration tests #965
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## master #965 +/- ##
===========================================
- Coverage 85.19% 69.63% -15.57%
===========================================
Files 91 109 +18
Lines 6301 8907 +2606
===========================================
+ Hits 5368 6202 +834
- Misses 933 2705 +1772 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
joaodordio
added
BCIT-EMBEDDED
joaodordio
changed the title
joaodordio
force-pushed
the
feature/SDK-15-BCIT-Embedded-Messages
branch
from
f3924ff to
822de29
Compare
![github-advanced-security[bot]](https://avatars.githubusercontent.com/in/57789?s=60&v=4){kind=small}
.github/workflows/bcit-integration-test-embedded-messages.yml
Dismissed
Show dismissed
Hide dismissed
joaodordio
commented
Oct 25, 2025
...terableSDK-Integration-Tester/App/EmbeddedMessage/EmbeddedMessageTestHostingController.swift
Show resolved
Hide resolved
joaodordio
commented
Oct 25, 2025
...on-test-app/IterableSDK-Integration-Tester/App/EmbeddedMessage/EmbeddedMessageTestView.swift
Show resolved
Hide resolved
joaodordio
commented
Oct 25, 2025
Comment on lines
+232
to
+248
| struct EmbeddedMessagesModalView: UIViewControllerRepresentable { | ||
| let messages: [IterableEmbeddedMessage] | ||
|
|
||
| func makeUIViewController(context: Context) -> UINavigationController { | ||
| let vc = EmbeddedMessagesViewController(messages: messages) | ||
| let nav = UINavigationController(rootViewController: vc) | ||
| return nav | ||
| } | ||
|
|
||
| func updateUIViewController(_ uiViewController: UINavigationController, context: Context) { | ||
| if let vc = uiViewController.viewControllers.first as? EmbeddedMessagesViewController { | ||
| vc.updateMessages(messages) | ||
| } | ||
| } | ||
| } | ||
|
|
||
| class EmbeddedMessagesViewController: UIViewController { |
There was a problem hiding this comment.
This UIViewController is used to render the SDK OOTB embedded views
…in permissions Co-authored-by: Copilot Autofix powered by AI <62310815+github-advanced-security[bot]@users.noreply.github.com>
…erable/iterable-swift-sdk into feature/SDK-15-BCIT-Embedded-Messages
Ayyanchira
approved these changes
Oct 27, 2025
Comment on lines
499
to
560
| func createEmbeddedCampaign( | ||
| name: String, | ||
| placementId: Int, | ||
| userListId: String? = nil, | ||
| userSegmentId: String? = nil, | ||
| dataFieldCriteria: [String: Any]? = nil, | ||
| messageContent: [String: Any], | ||
| completion: @escaping (Bool, String?) -> Void | ||
| ) { | ||
| let endpoint = "/api/embedded-messaging/campaigns/create" | ||
| recordAPICall(endpoint: endpoint) | ||
|
|
||
| var payload: [String: Any] = [ | ||
| "name": name, | ||
| "placementId": placementId, | ||
| "messageContent": messageContent, | ||
| "state": "Active" | ||
| ] | ||
|
|
||
| // Add targeting criteria | ||
| var targeting: [String: Any] = [:] | ||
| if let userListId = userListId { | ||
| targeting["listIds"] = [userListId] | ||
| } | ||
| if let userSegmentId = userSegmentId { | ||
| targeting["segmentIds"] = [userSegmentId] | ||
| } | ||
| if let dataFieldCriteria = dataFieldCriteria { | ||
| targeting["dataFields"] = dataFieldCriteria | ||
| } | ||
|
|
||
| if !targeting.isEmpty { | ||
| payload["targeting"] = targeting | ||
| } | ||
|
|
||
| performAPIRequest( | ||
| endpoint: endpoint, | ||
| method: "POST", | ||
| body: payload, | ||
| useServerKey: true | ||
| ) { result in | ||
| switch result { | ||
| case .success(let data): | ||
| do { | ||
| let json = try JSONSerialization.jsonObject(with: data) as? [String: Any] | ||
| if let campaignId = json?["campaignId"] as? String { | ||
| completion(true, campaignId) | ||
| } else if let campaignId = json?["campaignId"] as? Int { | ||
| completion(true, String(campaignId)) | ||
| } else { | ||
| completion(false, nil) | ||
| } | ||
| } catch { | ||
| print("❌ Error parsing embedded campaign creation response: \(error)") | ||
| completion(false, nil) | ||
| } | ||
| case .failure(let error): | ||
| print("❌ Error creating embedded campaign: \(error)") | ||
| completion(false, nil) | ||
| } | ||
| } | ||
| } |
There was a problem hiding this comment.
Nit pick - May not need creating campaign
I think its just better to create firs the placement id and one campaign on Iterable itself right?
I tested it with an already active campaign.
| } | ||
| } | ||
|
|
||
| func deleteEmbeddedCampaign(campaignId: String, completion: @escaping (Bool) -> Void) { |
There was a problem hiding this comment.
Same like above, if creation is removed, deletion can be removed too
| XCTAssertTrue(retrySuccessIndicator.waitForExistence(timeout: networkTimeout)) | ||
|
|
||
| screenshotCapture.captureScreenshot(named: "embedded-network-retry-success") | ||
| func testEmbeddedMessage() { |
There was a problem hiding this comment.
Optional - I realized we should have a comment section right above this primary method which tells whats expected for it to run.
Like a proper project with placement already created and a campaign which works for a dynamic list which looks for isPremium flag under user fields.
...egration-test-app/IterableSDK-Integration-Tester/App/InAppMessage/InAppMessageTestView.swift
Show resolved
Hide resolved
...on-test-app/IterableSDK-Integration-Tester/App/EmbeddedMessage/EmbeddedMessageTestView.swift
Show resolved
Hide resolved
...terableSDK-Integration-Tester/App/EmbeddedMessage/EmbeddedMessageTestHostingController.swift
Show resolved
Hide resolved
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
🔹 Jira Ticket(s)
✏️ Description
needs further investigation on why Silent Push with
"notificationType": "UpdateEmbedded"is not being sent to user.