-
Notifications
You must be signed in to change notification settings - Fork 35
[MOB-10141] make lint rules stricter #604
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
lposen
merged 31 commits into
2.0.0-alpha/master
from
2.0.0-alpha/MOB-10141-make-lint-rules-stricter
Dec 13, 2024
Merged
Changes from 1 commit
Commits
Show all changes
31 commits
Select commit
Hold shift + click to select a range
2ce56ae
Add ESLint configuration file and remove inline config from package.json
lposen 1d73a8d
Enhance ESLint configuration for TypeScript support: add TypeScript p…
lposen b6797da
Enhance ESLint configuration: add jest plugin and update lint command…
lposen 0bd3f0c
Fixed autofixabe lint issues
lposen 46c5710
Fixed linting issues for IterableInboxMessageCell
lposen bc32769
eslint fixes
lposen 6f87314
Add IterableEdgeInsetDetails type and update related classes for bett…
lposen 61d143d
Refactor IterableConfig and IterableInAppMessage for improved type sa…
lposen 888ee75
Enhance type safety by refining types in IterableCommerceItem, Iterab…
lposen a8ac6a1
Refactor fromDict methods in IterableAction and IterableActionContext…
lposen 7b0104a
Refactor Iterable class methods to enhance type safety; replace 'any'…
lposen ad2cf2d
Allow `requires` for package.json and in tests
lposen 9cbfc82
Refactor ESLint configuration for improved TypeScript support; update…
lposen 4b20c6e
Merge branch '2.0.0-alpha/MOB-9995-reorganize-source-code' into 2.0.0…
lposen 6ebc953
Merge branch '2.0.0-alpha/MOB-9995-reorganize-source-code' into 2.0.0…
lposen d76e662
Refactor ESLint configuration and improve type definitions. Excluded…
lposen 5d96ec5
Refactor ESLint configuration and move Prettier settings to a separat…
lposen cc96da8
Update ESLint configuration and ignore settings; remove node_modules …
lposen d029374
Enhance ESLint configuration and improve component styles for better …
lposen c556a9f
Refactor IterableInboxMessageDisplay to use color constants for impro…
lposen 835786f
Refactor IterableInboxMessageCell to use color constants for improved…
lposen 52a6422
Refactor IterableInboxEmptyState to use color constants for improved …
lposen e2ebcf1
Refactor IterableInbox to use color constants and improve style consi…
lposen 241c5f6
Refactor Commerce and Login components to use shadow constants for im…
lposen 15add53
Update ESLint configuration to use the full plugin path for better cl…
lposen 575cfbf
Merge branch '2.0.0-alpha/MOB-9995-reorganize-source-code' into 2.0.0…
lposen 989dead
Merge branch '2.0.0-alpha/MOB-9995-reorganize-source-code' into 2.0.0…
lposen e5ade24
Merge branch '2.0.0-alpha/MOB-9995-reorganize-source-code' into 2.0.0…
lposen 89ac82b
Merge branch '2.0.0-alpha/master' into 2.0.0-alpha/MOB-10141-make-lin…
evantk91 cbc3418
Merge branch '2.0.0-alpha/master' into 2.0.0-alpha/MOB-10141-make-lin…
lposen f2f5122
refactor: added constants instead of values as per PR review
lposen File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,7 @@ | ||
import type { IterableEdgeInsetDetails } from '../../core'; | ||
|
||
/** The raw in-App content details returned from the server */ | ||
export interface IterableHtmlInAppContentRaw { | ||
edgeInsets: IterableEdgeInsetDetails; | ||
html: string; | ||
} |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -1 +1,2 @@ | ||
export * from './IterableInAppContent'; | ||
export * from './IterableHtmlInAppContentRaw'; |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -7,14 +7,15 @@ import { | |
Text, | ||
TouchableOpacity, | ||
View, | ||
type PanResponderGestureState, | ||
type TextStyle, | ||
type ViewStyle, | ||
} from 'react-native'; | ||
|
||
import { IterableInboxDataModel } from '../classes'; | ||
import type { | ||
IterableInboxRowViewModel, | ||
IterableInboxCustomizations, | ||
IterableInboxRowViewModel, | ||
} from '../types'; | ||
|
||
// TODO: Change to component | ||
|
@@ -251,7 +252,7 @@ export const IterableInboxMessageCell = ({ | |
const FORCING_DURATION = 350; | ||
|
||
//If user swipes, either complete swipe or reset | ||
function userSwipedLeft(gesture: any) { | ||
function userSwipedLeft(gesture: PanResponderGestureState) { | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Nice catch! |
||
if (gesture.dx < -0.6 * contentWidth) { | ||
completeSwipe(); | ||
} else { | ||
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Seems like this should have a type like was done for IterableHtmlInAppContentRaw.