[MOB-10141] make lint rules stricter

src/inbox/components/IterableInboxEmptyState.tsx

@@ -1,6 +1,7 @@
 import { StyleSheet, Text, View } from 'react-native';
 
 import { type IterableInboxCustomizations } from '../types';
+import { ITERABLE_INBOX_COLORS } from '../constants';
 
 // TODO: Comment
 export interface IterableInboxEmptyStateProps {
@@ -27,37 +28,36 @@ export const IterableInboxEmptyState = ({
   const emptyStateTitle = customizations.noMessagesTitle;
   const emptyStateBody = customizations.noMessagesBody;
 
-  const { title, body } = styles;
-  let { container } = styles;
-
-  container = {
-    ...container,
-    height: height - navTitleHeight - tabBarHeight - tabBarPadding,
-  };
-
-  if (!isPortrait) {
-    container = { ...container, height: height - navTitleHeight };
-  }
-
   return (
-    <View style={container}>
-      <Text style={title}>
+    <View
+      style={[
+        styles.container,
+        {
+          height: isPortrait
+            ? height - navTitleHeight - tabBarHeight - tabBarPadding
+            : height - navTitleHeight,
+        },
+      ]}
+    >
+      <Text style={styles.title}>
         {emptyStateTitle ? emptyStateTitle : defaultTitle}
       </Text>
-      <Text style={body}>{emptyStateBody ? emptyStateBody : defaultBody}</Text>
+      <Text style={styles.body}>
+        {emptyStateBody ? emptyStateBody : defaultBody}
+      </Text>
     </View>
   );
 };
 
 const styles = StyleSheet.create({
   body: {
-    color: 'grey',
+    color: ITERABLE_INBOX_COLORS.TEXT,
     fontSize: 15,
   },
 
   container: {
     alignItems: 'center',
-    backgroundColor: 'whitesmoke',
+    backgroundColor: ITERABLE_INBOX_COLORS.CONTAINER_BACKGROUND,
     flexDirection: 'column',
     height: 0,
     justifyContent: 'center',

src/inbox/constants/colors.ts

@@ -3,6 +3,7 @@ export const ITERABLE_INBOX_COLORS = {
   CONTAINER_BACKGROUND_LIGHT: 'white',
   BUTTON_PRIMARY_TEXT: 'deepskyblue',
   DESTRUCTIVE: 'red',
+  TEXT: 'grey',
   TEXT_INVERSE: 'white',
   TEXT_MUTED: 'lightgray',
   BORDER: 'lightgray',