feat(SDK-557): bridge Android decryption failure handler to JS - #906
Draft
jferrao-itrbl wants to merge 2 commits into
Draft
jferrao-itrbl wants to merge 2 commits into
jferrao-itrbl wants to merge 2 commits into
Conversation
Expose IterableConfig.decryptionFailureHandler so RN apps can react when Android keychain PII decryption fails, matching native IterableConfig parity.
|
|
Coverage Impact Unable to calculate total coverage change because base branch coverage was not found. Modified Files with Diff Coverage (1)
🛟 Help
|
Avoid RN debug RedBox when apps set decryptionFailureHandler on iOS. Assert listenerCount in the omitted-callback test.
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
IterableConfig.decryptionFailureHandler(Android-only) and bridge nativeIterableDecryptionFailureHandlerviahandleDecryptionFailureCalled.Iterable.ts,decryptionFailureHandlerPresentintoDict(), tests, CHANGELOG, and publicIterableDecryptionFailuretype.Test plan
yarn typecheckyarn testcompileDebugJavaWithJavac— may fail until SDK-749 implementsIterableEmbeddedUpdateHandlersync callbacks (see Jira comments on SDK-557 / SDK-749)Jira
https://iterable.atlassian.net/browse/SDK-557