PHP 8.* compatibility

[lukasbesch]

No description provided.

[private-packagist]

composer.lock

Dev Package changes

Package	Operation	From	To	Changes
roave/security-advisories	upgrade	dev-master 598b39c	dev-master bcc78ca	diff

---

Settings · Docs · Powered by Private Packagist

[codepuncher]

Thanks for the PR @lukasbesch!

[codepuncher]

Anything else you want to add to this before I merge @lukasbesch?

[lukasbesch]

We could add type declarations instead of doc blocks for the class properties.

Will look into #37 (or #38 now) again at some point, because I just saw it being flagged in my IDE.

Other than that, I am just picking up an older project with Sage 9 at the moment, and will see if I run into more (actual) issues on PHP 8 and the current WordPress version.

So maybe leave it unmerged for now, I will give you an update in the following days.

[codepuncher]

We could add type declarations instead of doc blocks for the class properties.

I fully agree with this.

So maybe leave it unmerged for now

Up to you mate; I'm happy to merge now if you want to submit a new PR for types.