[02069] Refactor telemetry methods to accept context objects#3394
Merged
Conversation
Remove RepoUrl from PrCreatedContext record and stop sending repo_url to PostHog. The project field provides sufficient aggregation without exposing potentially sensitive repository URLs.
Collaborator
Staging removedStaging environment has been deleted for this PR. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Changes
Removed the
RepoUrlproperty fromPrCreatedContextand stopped sendingrepo_urlto PostHog in thepr_createdtelemetry event. Also removed the GitHub URL extraction logic fromJobServicethat populated this field. Theprojectandduration_secondsfields remain for non-identifying usage analytics.API Changes
PrCreatedContextrecord: removedstring RepoUrlparameter (was second positional parameter)TelemetryService.TrackPrCreated(): no longer sendsrepo_urlproperty to PostHogFiles Modified
RepoUrlfromPrCreatedContextrecordrepo_urlfrom PostHog capture dictionaryTrackPrCreatedcallCommits