Skip to content

Re-added username/password auth. Fixed issue when selecting Date/Tim…#8

Merged
J0hnG4lt merged 4 commits intoJ0hnG4lt:mainfrom
gizmodata:main
Sep 14, 2025
Merged

Re-added username/password auth. Fixed issue when selecting Date/Tim…#8
J0hnG4lt merged 4 commits intoJ0hnG4lt:mainfrom
gizmodata:main

Conversation

@prmoore77
Copy link
Contributor

…e columns

Hi @J0hnG4lt - this PR should allow username / password authentication (token is preferred if it is supplied).

It also fixes an issue I got when testing GizmoSQL - querying a table with a DATE column. I was getting:

An SQLException was provoked by the following failure: java.lang.ClassCastException: Cannot cast java.sql.Date to java.time.LocalDate

@prmoore77
Copy link
Contributor Author

Here is a screenshot showing the driver working:
image

@J0hnG4lt
Copy link
Owner

It's failing a check, @prmoore77

@prmoore77
Copy link
Contributor Author

It's failing a check, @prmoore77

but it worked on my laptop :) - ok, I'll try to fix. Thank you.

@prmoore77
Copy link
Contributor Author

Hi @J0hnG4lt - I pushed up some more changes to hopefully get past the build issue.

@prmoore77
Copy link
Contributor Author

Hi @J0hnG4lt - sorry for the repeated build issues. The jar builds ok for me on my laptop - but I'll use act so that I can try to emulate the Github Actions pipeline locally. I'll try to get a successful local pipeline run before pushing again. Thanks.

@prmoore77
Copy link
Contributor Author

I made more changes, and this time I got a successful linter validation result when running act locally:

|   Built :arrow-flight-sql driver in 23444 ms.
|   Verify :arrow-flight-sql driver
|     Check /Users/philip/Documents/git/metabase-flightsql-driver/metabase/resources/modules/arrow-flight-sql.metabase-driver.jar contains init class file metabase/driver/arrow_flight_sql__init.class
|       Driver init class file found.
|     Check /Users/philip/Documents/git/metabase-flightsql-driver/metabase/resources/modules/arrow-flight-sql.metabase-driver.jar contains metabase-plugin.yaml
|       Plugin manifest found; validating it
|       Plugin manifest passed spec validation
|     Check /Users/philip/Documents/git/metabase-flightsql-driver/metabase/resources/modules/arrow-flight-sql.metabase-driver.jar does not contain Clojure core classes
|     :arrow-flight-sql driver verification successful.

@J0hnG4lt J0hnG4lt merged commit 73ee3ae into J0hnG4lt:main Sep 14, 2025
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants