[MP] Perform bone conversion for jk2 models when running dedicated server. - #1329
Merged
Merged
Conversation
…rver. Previously using a jk2 glm, for instance a custom npc on a custom map, would lead to a crash when trying to perform g2 traces. This affected only dedicated servers.
Razish
approved these changes
May 12, 2026
SomaZ
approved these changes
May 12, 2026
Futuza
pushed a commit
to JKGDevs/JediKnightGalaxies
that referenced
this pull request
Jun 5, 2026
[MP] Perform bone conversion for jk2 models when running dedicated server.
SomaZ
added a commit
to SomaZ/OpenJK
that referenced
this pull request
Jul 12, 2026
[MP] Perform bone conversion for jk2 models when running dedicated server.
TwelveEyes
added a commit
to TwelveEyes/OpenJK
that referenced
this pull request
Jul 12, 2026
[rend2] Cache GPU shader programs [rend2] Minor cleanups [rend2] Fix dynamic lights on md3 surfaces [rend2] Shorten lightall names to prevent Q_strcat overflow error [rend2] Fix clamping to reported max texture size [JO] Make mapOverbrightbits 1 default and fix rend2 overbright issues JOs default is overbrightbits 1. Maps looked very dark without this change. Merge pull request JACoders#1329 from Daggolin/dedicated-jk2-glm-crash [MP] Perform bone conversion for jk2 models when running dedicated server.
TwelveEyes
added a commit
to TwelveEyes/OpenJK
that referenced
this pull request
Jul 12, 2026
[rend2] Cache GPU shader programs [rend2] Minor cleanups [rend2] Fix dynamic lights on md3 surfaces [rend2] Shorten lightall names to prevent Q_strcat overflow error [rend2] Fix clamping to reported max texture size [JO] Make mapOverbrightbits 1 default and fix rend2 overbright issues JOs default is overbrightbits 1. Maps looked very dark without this change. Merge pull request JACoders#1329 from Daggolin/dedicated-jk2-glm-crash [MP] Perform bone conversion for jk2 models when running dedicated server.
TwelveEyes
added a commit
to TwelveEyes/OpenJK
that referenced
this pull request
Jul 12, 2026
[rend2] Cache GPU shader programs [rend2] Minor cleanups [rend2] Fix dynamic lights on md3 surfaces [rend2] Shorten lightall names to prevent Q_strcat overflow error [rend2] Fix clamping to reported max texture size [JO] Make mapOverbrightbits 1 default and fix rend2 overbright issues JOs default is overbrightbits 1. Maps looked very dark without this change. Merge pull request JACoders#1329 from Daggolin/dedicated-jk2-glm-crash [MP] Perform bone conversion for jk2 models when running dedicated server.
TwelveEyes
added a commit
to TwelveEyes/OpenJK
that referenced
this pull request
Jul 17, 2026
[rend2] Cache GPU shader programs [rend2] Minor cleanups [rend2] Fix dynamic lights on md3 surfaces [rend2] Shorten lightall names to prevent Q_strcat overflow error [rend2] Fix clamping to reported max texture size [JO] Make mapOverbrightbits 1 default and fix rend2 overbright issues JOs default is overbrightbits 1. Maps looked very dark without this change. Merge pull request JACoders#1329 from Daggolin/dedicated-jk2-glm-crash [MP] Perform bone conversion for jk2 models when running dedicated server. [rend2] Add r_refractionChromaticAberration Adds a cvar to adjust chromatic aberration effect strength when refractive surfaces are drawn.
TwelveEyes
added a commit
to TwelveEyes/OpenJK
that referenced
this pull request
Jul 17, 2026
[rend2] Cache GPU shader programs [rend2] Minor cleanups [rend2] Fix dynamic lights on md3 surfaces [rend2] Shorten lightall names to prevent Q_strcat overflow error [rend2] Fix clamping to reported max texture size [JO] Make mapOverbrightbits 1 default and fix rend2 overbright issues JOs default is overbrightbits 1. Maps looked very dark without this change. Merge pull request JACoders#1329 from Daggolin/dedicated-jk2-glm-crash [MP] Perform bone conversion for jk2 models when running dedicated server. [rend2] Add r_refractionChromaticAberration Adds a cvar to adjust chromatic aberration effect strength when refractive surfaces are drawn. [rend2] Get rid of most gcc warnings on rend2 compile
TwelveEyes
added a commit
to TwelveEyes/OpenJK
that referenced
this pull request
Jul 18, 2026
[rend2] Cache GPU shader programs [rend2] Minor cleanups [rend2] Fix dynamic lights on md3 surfaces [rend2] Shorten lightall names to prevent Q_strcat overflow error [rend2] Fix clamping to reported max texture size [JO] Make mapOverbrightbits 1 default and fix rend2 overbright issues JOs default is overbrightbits 1. Maps looked very dark without this change. Merge pull request JACoders#1329 from Daggolin/dedicated-jk2-glm-crash [MP] Perform bone conversion for jk2 models when running dedicated server. [rend2] Add r_refractionChromaticAberration Adds a cvar to adjust chromatic aberration effect strength when refractive surfaces are drawn. [rend2] Get rid of most gcc warnings on rend2 compile [rend2] Undo temp bone memset -> initializer [rend2] Make cubemap luma scaling more robust [rend2] Cleanup uniforms Those were all put into ubos some time ago, so no need for them to exist anymore in this form. [rend2] Fix gore uploads being dependant on correct backEndData->realFrameNumber Just mark the gore data as cached when its actually drawn.
TwelveEyes
added a commit
to TwelveEyes/OpenJK
that referenced
this pull request
Jul 18, 2026
[rend2] Cache GPU shader programs [rend2] Minor cleanups [rend2] Fix dynamic lights on md3 surfaces [rend2] Shorten lightall names to prevent Q_strcat overflow error [rend2] Fix clamping to reported max texture size [JO] Make mapOverbrightbits 1 default and fix rend2 overbright issues JOs default is overbrightbits 1. Maps looked very dark without this change. Merge pull request JACoders#1329 from Daggolin/dedicated-jk2-glm-crash [MP] Perform bone conversion for jk2 models when running dedicated server. [rend2] Add r_refractionChromaticAberration Adds a cvar to adjust chromatic aberration effect strength when refractive surfaces are drawn. [rend2] Get rid of most gcc warnings on rend2 compile [rend2] Undo temp bone memset -> initializer [rend2] Make cubemap luma scaling more robust [rend2] Cleanup uniforms Those were all put into ubos some time ago, so no need for them to exist anymore in this form. [rend2] Fix gore uploads being dependant on correct backEndData->realFrameNumber Just mark the gore data as cached when its actually drawn. [rend2] Improve flare rendering Doesn't readback the depthbuffer anymore to determain if a flare is visable or not. It will now test depth in the vertex shader that is running for the flare and creates degenerate triangles if it's concidered to be occluded.
TwelveEyes
added a commit
to TwelveEyes/OpenJK
that referenced
this pull request
Jul 18, 2026
[rend2] Cache GPU shader programs [rend2] Minor cleanups [rend2] Fix dynamic lights on md3 surfaces [rend2] Shorten lightall names to prevent Q_strcat overflow error [rend2] Fix clamping to reported max texture size [JO] Make mapOverbrightbits 1 default and fix rend2 overbright issues JOs default is overbrightbits 1. Maps looked very dark without this change. Merge pull request JACoders#1329 from Daggolin/dedicated-jk2-glm-crash [MP] Perform bone conversion for jk2 models when running dedicated server. [rend2] Add r_refractionChromaticAberration Adds a cvar to adjust chromatic aberration effect strength when refractive surfaces are drawn. [rend2] Get rid of most gcc warnings on rend2 compile [rend2] Undo temp bone memset -> initializer [rend2] Make cubemap luma scaling more robust [rend2] Cleanup uniforms Those were all put into ubos some time ago, so no need for them to exist anymore in this form. [rend2] Fix gore uploads being dependant on correct backEndData->realFrameNumber Just mark the gore data as cached when its actually drawn. [rend2] Improve flare rendering Doesn't readback the depthbuffer anymore to determain if a flare is visable or not. It will now test depth in the vertex shader that is running for the flare and creates degenerate triangles if it's concidered to be occluded. [rend2] Make sure flares can't write to depthbuffer as well
TwelveEyes
added a commit
to TwelveEyes/OpenJK
that referenced
this pull request
Jul 19, 2026
[rend2] Cache GPU shader programs [rend2] Minor cleanups [rend2] Fix dynamic lights on md3 surfaces [rend2] Shorten lightall names to prevent Q_strcat overflow error [rend2] Fix clamping to reported max texture size [JO] Make mapOverbrightbits 1 default and fix rend2 overbright issues JOs default is overbrightbits 1. Maps looked very dark without this change. Merge pull request JACoders#1329 from Daggolin/dedicated-jk2-glm-crash [MP] Perform bone conversion for jk2 models when running dedicated server. [rend2] Add r_refractionChromaticAberration Adds a cvar to adjust chromatic aberration effect strength when refractive surfaces are drawn. [rend2] Get rid of most gcc warnings on rend2 compile [rend2] Undo temp bone memset -> initializer [rend2] Make cubemap luma scaling more robust [rend2] Cleanup uniforms Those were all put into ubos some time ago, so no need for them to exist anymore in this form. [rend2] Fix gore uploads being dependant on correct backEndData->realFrameNumber Just mark the gore data as cached when its actually drawn. [rend2] Improve flare rendering Doesn't readback the depthbuffer anymore to determain if a flare is visable or not. It will now test depth in the vertex shader that is running for the flare and creates degenerate triangles if it's concidered to be occluded. [rend2] Make sure flares can't write to depthbuffer as well [rend2] Fix deformVertexes bulge speed [rend2] Implement alphaGen lightingSpecular for md3 and glm models It always used the approximation that is used for worldsurfaces instead of using the lightgrid info.
TwelveEyes
added a commit
to TwelveEyes/OpenJK
that referenced
this pull request
Jul 21, 2026
[rend2] Cache GPU shader programs [rend2] Minor cleanups [rend2] Fix dynamic lights on md3 surfaces [rend2] Shorten lightall names to prevent Q_strcat overflow error [rend2] Fix clamping to reported max texture size [JO] Make mapOverbrightbits 1 default and fix rend2 overbright issues JOs default is overbrightbits 1. Maps looked very dark without this change. Merge pull request JACoders#1329 from Daggolin/dedicated-jk2-glm-crash [MP] Perform bone conversion for jk2 models when running dedicated server. [rend2] Add r_refractionChromaticAberration Adds a cvar to adjust chromatic aberration effect strength when refractive surfaces are drawn. [rend2] Get rid of most gcc warnings on rend2 compile [rend2] Undo temp bone memset -> initializer [rend2] Make cubemap luma scaling more robust [rend2] Cleanup uniforms Those were all put into ubos some time ago, so no need for them to exist anymore in this form. [rend2] Fix gore uploads being dependant on correct backEndData->realFrameNumber Just mark the gore data as cached when its actually drawn. [rend2] Improve flare rendering Doesn't readback the depthbuffer anymore to determain if a flare is visable or not. It will now test depth in the vertex shader that is running for the flare and creates degenerate triangles if it's concidered to be occluded. [rend2] Make sure flares can't write to depthbuffer as well [rend2] Fix deformVertexes bulge speed [rend2] Implement alphaGen lightingSpecular for md3 and glm models It always used the approximation that is used for worldsurfaces instead of using the lightgrid info. [rend2] Fix more issues with picmipping and r_simpleMipMaps
TwelveEyes
added a commit
to TwelveEyes/OpenJK
that referenced
this pull request
Aug 8, 2026
[rend2] Cache GPU shader programs [rend2] Minor cleanups [rend2] Fix dynamic lights on md3 surfaces [rend2] Shorten lightall names to prevent Q_strcat overflow error [rend2] Fix clamping to reported max texture size [JO] Make mapOverbrightbits 1 default and fix rend2 overbright issues JOs default is overbrightbits 1. Maps looked very dark without this change. Merge pull request JACoders#1329 from Daggolin/dedicated-jk2-glm-crash [MP] Perform bone conversion for jk2 models when running dedicated server. [rend2] Add r_refractionChromaticAberration Adds a cvar to adjust chromatic aberration effect strength when refractive surfaces are drawn. [rend2] Get rid of most gcc warnings on rend2 compile [rend2] Undo temp bone memset -> initializer [rend2] Make cubemap luma scaling more robust [rend2] Cleanup uniforms Those were all put into ubos some time ago, so no need for them to exist anymore in this form. [rend2] Fix gore uploads being dependant on correct backEndData->realFrameNumber Just mark the gore data as cached when its actually drawn. [rend2] Improve flare rendering Doesn't readback the depthbuffer anymore to determain if a flare is visable or not. It will now test depth in the vertex shader that is running for the flare and creates degenerate triangles if it's concidered to be occluded. [rend2] Make sure flares can't write to depthbuffer as well [rend2] Fix deformVertexes bulge speed [rend2] Implement alphaGen lightingSpecular for md3 and glm models It always used the approximation that is used for worldsurfaces instead of using the lightgrid info. [rend2] Fix more issues with picmipping and r_simpleMipMaps [rend2] Fix mergeLeafSurfaces A single break; prevented the code to fill the new indices past the first mergable surface. Also using R_CreateIBO now to get debug names.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Perform bone conversion for jk2 models when running dedicated server.
Previously using a jk2 glm, for instance a custom npc on a custom map, would lead to a crash when trying to perform g2 traces. This affected only dedicated servers.