Fix knot tracking for tunnels and threads - #156
Closed
willvale wants to merge 3 commits into
Closed
Conversation
Fix knot tracking for tunnels and threads Knots, tunnels and threads should all have entry tracked, otherwise they don't get per-knot tags. * Set track_not_visit for all frames other than functions. * Added new test TagsAndBranching which tests that tags end up visible in inkcpp for all knot types.
Contributor
Author
|
This isn't quite ready after all. The idea is good but while it was passing all tests against my previous version, it's not working against the latest inkcpp changes. I will tweak and re-open in time. |
Owner
|
Thanks for noticing this. Yeah, the last inkcpp changes were severe around the knot count (I did initially not expect it to be this complicated). I'm looking forword to your PR |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Knots, tunnels and threads should all have entry and exit tracked, otherwise they don't get the correct per-knot tags. This only works for "normal" knots at the moment but is relatively easy to get it to work for the other two.
TagsAndBranchingwhich tests that tags end up visible in inkcpp for all knot types.NB: The correct behaviour is visible in Inky using the test script in this PR.