GBM #2
Open
GBM #2
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I disagree that we need to distribute this file. If we would distribute it with this repository, we would need to update it whenever a new version comes out. Why not modify the README and add instructions to install the |
|
Yes, I agree, will update the README soon |
|
Does this build? |
|
The header in the "defines.h" file will have to be changed from "#include <gbm/gbm.h>" to "#include <gbm.h>". It does build if we do that. |
|
I am not sure if this will work on all platforms, for example on my Arch I don't have this header in |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In this PR, we have added the "gbm.h" header file in the required directory.
This dependency is not present in the current repository for host and caused an error on the host while building the project.