Skip to content

Fixed possible race condition on downloading datasets while using multiple GPUs #12

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
guyleaf wants to merge 2 commits into
base: main
Choose a base branch
from
Open

Fixed possible race condition on downloading datasets while using multiple GPUs #12

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
3bb8932
Fixed possible race condition while downloading datasets
guyleaf Oct 14, 2023
97426fa
Update the comment of building dataloader in main.py
guyleaf Oct 14, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
14 changes: 13 additions & 1 deletion main.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -42,7 +42,19 @@ def main(args):

cudnn.benchmark = True

data_loader, class_mask = build_continual_dataloader(args)
if args.distributed:
if utils.is_main_process():
# prepare datasets on main process first to avoid race condition on downloading datasets
data_loader, class_mask = build_continual_dataloader(args)

# wait until the main process complete
torch.distributed.barrier()

# let other processes prepare datasets
if not utils.is_main_process():
data_loader, class_mask = build_continual_dataloader(args)
else:
data_loader, class_mask = build_continual_dataloader(args)

print(f"Creating original model: {args.model}")
original_model = create_model(
Expand Down