Complete migration of Crypto Loans API from v1(partial support) to v2(full support) #1503
Conversation
- Changed method orders to replicate api layout - Tagged methods as MISSING or RETIRED - Restructured regions
Updated: Methods: - `Get Collateral Assets` - `GetLoanableAssetsAsync` Models: - `BinanceCryptoLoanAsset` - `BinanceCryptoLoanCollateralAsset`
Updated: Methods: - `BorrowAsync` - `RepayAsync` - `RepayCollateralAsync` - `AdjustLTVAsync` Models: - `BinanceCryptoLoanBorrow` - `BinanceCryptoLoanRepay` - `BinanceCryptoLoanLtvAdjust` Added Enum: - `RepayStatus`
# Summary: ## Methods: #### 1. Added missing methods: - `GetFlexibleLtvAdjustHistoryAsync` - `GetFlexibleBorrowHistoryAsync` - `GetLiquidationHistoryAsync` - `GetRepayHistoryAsync` #### 2. Updated outdated/retired method to API v2**: - `GetCollateralRepayRateAsync` - `GetOpenBorrowOrdersAsync` ## Enums: #### Added enums: - `FlexibleBorrowStatus` - `LoanLiquidationStatus` ## Models: #### 1. Added models for missing methods: - `BinanceCryptoLoanFlexibleBorrowRecord` - `BinanceCryptoLoanFlexibleRepayRecord` - `BinanceCryptoLoanFlexibleLtvAdjustRecord` - `BinanceCryptoLoanLiquidationRecord` #### 2. Refactored existing models: - `BinanceCryptoLoanOpenBorrowOrder` - `BinanceCryptoLoanRepayRate`
| parameters.AddOptionalParameter("loanAsset", loanAsset); | ||
| parameters.AddOptionalParameter("collateralAsset", collateralAsset); | ||
| parameters.AddOptionalParameter("current", page?.ToString(CultureInfo.InvariantCulture)); |
There was a problem hiding this comment.
This works fine, but there are also helper methods you can use instead.
You could use parameters.AddOptionalString("current", page) which will internally check for null and convert to string.
There was a problem hiding this comment.
Changed this in Updated string parameter handling logic Commit
| await tester.ValidateAsync(client => client.GeneralApi.CryptoLoans.CustomizeMarginCallAsync(123), "CustomizeMarginCall"); | ||
| } | ||
| //[Test] | ||
| //public async Task ValidateGeneralCryptoLoansCalls() // TODO Update Crypto Loans Tests for API v2 |
There was a problem hiding this comment.
Is this something you could also add?
There was a problem hiding this comment.
Yeah, I was thinking about doing single PR with test fixes, I noticed that there are lots of general client ones missing. I had an idea that I would add support for missing services like NFT, Gift Cards, VIP Loans, etc and then I would make a single big PR focused on tests. I am currently working on VIP Loans, I hope that I will be done today/tomorrow. And I could start working on tests after that.
Moved from manual string conversion to build in helper `AddOptionalString`
Refactored Crypto Loans General client that partially supported Crypto Loans API v1, to make it fully support new Crypto Loans API v2.
Endpoints:
Added support for new endpoints:
RepayCollateralAsyncGetFlexibleBorrowHistoryAsyncGetLiquidationHistoryAsyncGetFlexibleRepayHistoryAsyncMigrated outdated endpoints from API v1 to API v2 standard:
GetCollateralAssetsAsyncGetLoanableAssetsAsyncBorrowAsyncRepayAsyncAdjustLTVAsyncGetFlexibleLtvAdjustHistoryAsyncGetCollateralRepayRateAsyncGetOpenBorrowOrdersAsyncFixed parameter naming issue in v1 endpoints:
GetBorrowHistoryAsyncGetLtvAdjustHistoryAsyncGetRepayHistoryAsyncRemoved fully retired endpoint:
Customize Margin CallEnums:
Added new Enums:
RepayStatusFlexibleBorrowStatusFlexibleBorrowRecordStatusLoanLiquidationStatusModels:
Added new Models:
BinanceCryptoLoanFlexibleBorrowRecordBinanceCryptoLoanFlexibleLtvAdjastRecordBinanceCryptoLoanFlexibleRepayRecordBinanceCryptoLoanLiquidationRecordMigrated outdated models from API v1 to API v2 standard:
BinanceRestClientGeneralApiLoansBinanceCryptoLoanAssetBinanceCryptoLoanCollateralAssetBinanceCryptoLoanBorrowBinanceCryptoLoanLtvAdjustBinanceCryptoLoanRepayBinanceCryptoLoanOpenBorrowOrderBinanceCryptoLoanRepayRateBinanceCryptoLoanFlexibleBorrowRecordOther Changes:
IBinanceRestClientGeneralApiLoansinterface to match new endpoints.References: