Skip to content

Make symbol parameter optional in GetFundingRatesAsync #1580

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
DShaurin wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Make symbol parameter optional in GetFundingRatesAsync #1580

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 4 additions & 4 deletions Binance.Net/Clients/UsdFuturesApi/BinanceRestClientUsdFuturesApiExchangeData.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -135,12 +135,12 @@ public async Task<WebCallResult<BinanceFuturesFundingInfo[]>> GetFundingInfoAsyn
#region Get Funding Rate History

/// <inheritdoc />
public async Task<WebCallResult<BinanceFuturesFundingRateHistory[]>> GetFundingRatesAsync(string symbol, DateTime? startTime = null, DateTime? endTime = null, int? limit = null, CancellationToken ct = default)
public async Task<WebCallResult<BinanceFuturesFundingRateHistory[]>> GetFundingRatesAsync(string? symbol, DateTime? startTime = null, DateTime? endTime = null, int? limit = null, CancellationToken ct = default)
{
limit?.ValidateIntBetween(nameof(limit), 1, 1000);
var parameters = new ParameterCollection {
{ "symbol", symbol }
};
var parameters = new ParameterCollection();

parameters.AddOptionalParameter("symbol", symbol);
parameters.AddOptionalParameter("startTime", DateTimeConverter.ConvertToMilliseconds(startTime));
parameters.AddOptionalParameter("endTime", DateTimeConverter.ConvertToMilliseconds(endTime));
parameters.AddOptionalParameter("limit", limit?.ToString(CultureInfo.InvariantCulture));
Expand Down
8 changes: 4 additions & 4 deletions Binance.Net/Interfaces/Clients/UsdFuturesApi/IBinanceRestClientUsdFuturesApiExchangeData.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -99,21 +99,21 @@ public interface IBinanceRestClientUsdFuturesApiExchangeData
Task<WebCallResult<BinanceFuturesFundingInfo[]>> GetFundingInfoAsync(CancellationToken ct = default);

/// <summary>
/// Get funding rate history for the provided symbol
/// Get funding rate history for the provided symbol or for all symbols
/// <para>
/// Docs:<br />
/// <a href="https://developers.binance.com/docs/derivatives/usds-margined-futures/market-data/rest-api/Get-Funding-Rate-History" /><br />
/// Endpoint:<br />
/// GET /fapi/v1/fundingRate
/// </para>
/// </summary>
/// <param name="symbol">["<c>symbol</c>"] The symbol to get the data for, for example `ETHUSDT`</param>
/// <param name="symbol">["<c>symbol</c>"] The symbol to get the data for, for example `ETHUSDT`. Or null to get the data for all symbols</param>
/// <param name="startTime">["<c>startTime</c>"] Start time to get funding rate history</param>
/// <param name="endTime">["<c>endTime</c>"] End time to get funding rate history</param>
/// <param name="limit">["<c>limit</c>"] Max number of results</param>
/// <param name="limit">["<c>limit</c>"] Max number of results. Default 100, max 1000</param>
/// <param name="ct">Cancellation token</param>
/// <returns>The funding rate history for the provided symbol</returns>
Task<WebCallResult<BinanceFuturesFundingRateHistory[]>> GetFundingRatesAsync(string symbol, DateTime? startTime = null, DateTime? endTime = null, int? limit = null, CancellationToken ct = default);
Task<WebCallResult<BinanceFuturesFundingRateHistory[]>> GetFundingRatesAsync(string? symbol, DateTime? startTime = null, DateTime? endTime = null, int? limit = null, CancellationToken ct = default);

/// <summary>
/// Gets Top Trader Long/Short Ratio (Accounts)
Expand Down
Loading